fix: bound the concurrency of the batch dispatch fan-out (#264) - #526
Merged
Conversation
s2x
force-pushed
the
fix/264-bound-batch-dispatch-concurrency
branch
from
September 9, 2026 21:09
280b766 to
eb2c257
Compare
s2x
marked this pull request as ready for review
September 9, 2026 21:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #264
Changes
RawKvClient::batchGet()/batchPut()/batchDelete():RawKvBatchnow dispatches sub-batches in windows via the existingexecuteParallelCapped()executor instead of the unboundedexecuteParallel()RawKvBatchto the existingoptions['maxConcurrency']option onRawKvClient::create()(default 16, same bound as fanned-out range operations)tests/Unit/RawKv/RawKvBatchConcurrencyCapTest.phpasserting the peak in-flight count equals the window size (Grpc suite)Changelog
RawKvClientbatch operations is now bounded bymaxConcurrency(default 16), preventing unbounded gRPC call/memory blow-up on very large batches ([GRPC-05] Bound the concurrency of the batch dispatch fan-out #264)Code Review