Skip to content

[Chore] Declare symfony/event-dispatcher-contracts and symfony/service-contracts imported directly (8 src/ files) #808

Description

@s2x

Description

Follow-up to #588 (which grepped Symfony\\Component only): 7 src/ files import Symfony\\Contracts\\EventDispatcher\\* (ProcessHandler, TaskHandler, all four Event/*Event classes, WorkermanCompilerPass) and Middleware/SymfonyController.php:17 imports Symfony\\Contracts\\Service\\ResetInterface, but neither symfony/event-dispatcher-contracts nor symfony/service-contracts is declared — both resolve transitively (currently v3.7.0 via symfony/event-dispatcher / symfony/dependency-injection).

Where

Suggested fix

Add the composer-require-checker CI step from #588's acceptance criteria to settle which symbols are unknown, then declare the two -contracts packages explicitly. Note: both are 2.x/3.x-versioned (no 6.4/7.4/8.0 line), so declaring them requires extending the tests.yaml matrix sed exclusion the same way #806 did for deprecation-contracts.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    code-qualityCode quality improvementsenhancementNew feature or requestminorMinor priority - code quality

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions