Skip to content

[Tests] testReloadDoesNotBreakServer flaky — single post-reload request races worker restart (cURL error 56) #810

Description

@s2x

Description

The test sends reload, waits for TCP port-up, then fires a single HTTP request with no retry. Port-up does not mean worker-ready after a reload, so the request can land mid-restart and die with cURL error 56: Recv failure: Connection reset by peer.

Flaked twice during the #588 cycle (PR #806) with the identical signature on different legs, green on re-run / other legs both times:

  • run 34405095115, Tests (8.2, 6.4.*) leg
  • run 34405583432, Tests (8.4, 8.0.*) leg

Where

  • tests/WorkermanCommandTest.php:81-93

Suggested fix

Retry the post-reload request (a few attempts with a short sleep) instead of firing once, or wait for an actual HTTP 200 rather than TCP port-up before asserting.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingminorMinor priority - code quality

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions