Fix #4423: Auto-parse JSON string config in Mem0Storage#4424
Closed
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Closed
Fix #4423: Auto-parse JSON string config in Mem0Storage#4424devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
Co-Authored-By: João <joao@crewai.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
Author
|
Closing due to inactivity for more than 7 days. Configure here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4423: Auto-parse JSON string config in Mem0Storage
Summary
Mem0Storagecrashes withAttributeError: 'str' object has no attribute 'get'whenconfigis provided as a JSON string instead of a dict. This is common when configs are loaded from environment variables, CLI arguments, or config files.The fix adds a
_parse_configstatic method that:dictconfigs through unchanged (existing behavior)TypeErrormessages for invalid JSON strings, JSON that doesn't decode to a dict, or unsupported types (e.g.int)Review & Testing Checklist for Human
""config is acceptable — previouslyconfig or {}would silently convert it to{}, now it raisesTypeErrorsince""is not valid JSON. This is arguably stricter but more correct.TypeErroris the right exception type for all three error cases (invalid JSON, non-dict JSON, wrong type). Could argueValueErrorfor the JSON decode failure.'{"agent_id":"x","user_id":"y"}'toMem0Storage(type="external", config=...)and verify it initializes correctly end-to-end.Notes