Skip to content

Add section on UK OneId#306

Merged
mickhansen merged 1 commit intomasterfrom
add-one-id-documentation
Apr 1, 2026
Merged

Add section on UK OneId#306
mickhansen merged 1 commit intomasterfrom
add-one-id-documentation

Conversation

@Xephyz
Copy link
Copy Markdown
Contributor

@Xephyz Xephyz commented Mar 31, 2026

This adds a page under eIDs for the United Kingdom OneID product.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 31, 2026

Deploy Preview for criipto-docs ready!

Name Link
🔨 Latest commit 2cf7b86
🔍 Latest deploy log https://app.netlify.com/projects/criipto-docs/deploys/69cc039c115fb00008199d6f
😎 Deploy Preview https://deploy-preview-306--criipto-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Xephyz Xephyz requested review from kasperhj and mickhansen March 31, 2026 10:49
@mickhansen mickhansen requested review from fkj and nmoskaleva March 31, 2026 10:50
Copy link
Copy Markdown
Collaborator

@mickhansen mickhansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we generally prefer markdown tables to HTML tables, mind converting them?

@Xephyz
Copy link
Copy Markdown
Contributor Author

Xephyz commented Mar 31, 2026

I think we generally prefer markdown tables to HTML tables, mind converting them?

I started with Markdown tables, but it didn't display correctly for me and I noticed other pages used the html tables, so I actually converted them to HTML.

Are you sure Markdown tables are supported?

@mickhansen
Copy link
Copy Markdown
Collaborator

I started with Markdown tables, but it didn't display correctly for me and I noticed other pages used the html tables, so I actually converted them to HTML.

@Xephyz I am probably misremembering then. @nmoskaleva is the docs master

@nmoskaleva
Copy link
Copy Markdown
Collaborator

@mickhansen The last table I added was in the CIBA docs, and it's HTML. So HTML is definitely the standard :)

@Xephyz Xephyz requested a review from mickhansen March 31, 2026 11:29
Copy link
Copy Markdown
Collaborator

@nmoskaleva nmoskaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A few comments.

@Xephyz Xephyz requested review from mickhansen and nmoskaleva March 31, 2026 11:59
Copy link
Copy Markdown
Collaborator

@nmoskaleva nmoskaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Copy Markdown
Collaborator

@fkj fkj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the "Products and their supported scopes" is missing a title for the right-most column. Probably should be something like "Supported scopes".
Otherwise, looks good!

@mickhansen
Copy link
Copy Markdown
Collaborator

@Xephyz remember to autosquash, this repo does not have a CI check against it.

@Xephyz Xephyz force-pushed the add-one-id-documentation branch from d26f8cb to 2cf7b86 Compare March 31, 2026 17:25
@Xephyz Xephyz requested review from fkj and nmoskaleva March 31, 2026 17:26
@mickhansen mickhansen merged commit 56b96d5 into master Apr 1, 2026
5 checks passed
@mickhansen mickhansen deleted the add-one-id-documentation branch April 1, 2026 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants