- Adds custom field types to Cro::WebApp #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi Xliff I would be happy to review this PR (also I note a few older stranded PRs in your name... will try to get to these one by one). On this one, please can you provide a test and some doc with an example (not least so that I can get my head around what kind of things you have in mind as custom form fields) ... |
Collaborator
Author
|
Working on it, thanks. Hope to have this done by Friday
…On Sat, Apr 19, 2025 at 9:10 AM librasteve ***@***.***> wrote:
Hi Xliff
I would be happy to review this PR (also I note a few older stranded PRs
in your name... will try to get to these one by one).
On this one, please can you provide a test and some doc with an example
(not least so that I can get my head around what kind of things you have in
mind as custom form fields) ...
—
Reply to this email directly, view it on GitHub
<#98 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEU5QQAJWXHOADCFTZTA4D22JDNRAVCNFSM6AAAAAB3OEEMZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJWG4YDCNZVGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
*librasteve* left a comment (croservices/cro-webapp#98)
<#98 (comment)>
Hi Xliff
I would be happy to review this PR (also I note a few older stranded PRs
in your name... will try to get to these one by one).
On this one, please can you provide a test and some doc with an example
(not least so that I can get my head around what kind of things you have in
mind as custom form fields) ...
—
Reply to this email directly, view it on GitHub
<#98 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEU5QQAJWXHOADCFTZTA4D22JDNRAVCNFSM6AAAAAB3OEEMZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJWG4YDCNZVGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.