Avoid setting tags if there are no changes, prevent conflict on every resource creation #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… resource creation
I've observed this error message on every resource creation:
2025-03-06T09:21:58+01:00 DEBUG provider-aws Cannot initialize managed resource {"controller": "managed/ec2.aws.upbound.io/v1beta1, kind=securitygroup",
"request": {"name":"example4"},
"uid": "6110a508-2be7-470c-8d00-10302dc9c270",
"version": "101685",
"external-name": "",
"error": "Operation cannot be fulfilled on securitygroups.ec2.aws.upbound.io \"example4\": the object has been modified; please apply your changes to the latest version and try again"}
By avoiding this unneccessary unconditional Update API call, we get rid of this error message.
Signed-off-by: Carl Henrik Lunde <[email protected]>
While the AWS SDK typically requires this, I don't believe there is any reason for this here with the kubernetes objects. Signed-off-by: Carl Henrik Lunde <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've observed this error message on every resource creation:
By avoiding this unneccessary unconditional Update API call, we get rid of this error message.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested