Skip to content

add creation_time to lock definition - #278

Merged
jessegeens merged 1 commit into
mainfrom
lock-creation-time
Aug 12, 2026
Merged

jessegeens merged 1 commit into
mainfrom
lock-creation-time

Conversation

@jessegeens

@jessegeens jessegeens commented Aug 11, 2026 •

Copy link
Copy Markdown
Contributor

@aduffeck @micbar @butonic any objections? :)

@glpatcern

Copy link
Copy Markdown
Member

I think this was discussed in the past and I gently objected against :-)

My objection was and is: the only value that matters for a lock is the expiration time, not the creation time. In addition, when an application (typically via WOPI) holds a lock, it can refresh it "forever", until a user works on the file, making the timing information essentially irrelevant.

What is the purpose of bringing this information to the average user? IMHO users would be induced to make (likely wrong) assumptions by knowing that a file was locked "1 hour ago" or "1 minute ago", whereas they should just be informed that "a file is locked by user abc" or "by app xyz".

@diocas diocas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an optional field. Might be useful to display that info for users, in case a file has been locked for a long time, might lead to the realization that it was forgotten.

@jessegeens
jessegeens merged commit f11a056 into main Aug 12, 2026
2 checks passed
@jessegeens
jessegeens deleted the lock-creation-time branch August 27, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants