Skip to content

replaced genootschapen with genootschappen#1074

Open
TimonBoer wants to merge 1 commit intostagingfrom
fix/genootschapen-dyslexia
Open

replaced genootschapen with genootschappen#1074
TimonBoer wants to merge 1 commit intostagingfrom
fix/genootschapen-dyslexia

Conversation

@TimonBoer
Copy link
Copy Markdown
Contributor

@TimonBoer TimonBoer commented Feb 16, 2026

Summary

replaced genootschapen with genootschappen

Other information

also in amber-api

Summary by CodeRabbit

  • Bug Fixes
    • Corrected spelling inconsistencies in activity category data.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 16, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

This PR corrects a spelling inconsistency in the ActivityCategories array by updating 'genootschapen' to 'genootschappen' across two files: the constants definition and the mirage factory fixture.

Changes

Cohort / File(s) Summary
Spelling Correction
app/constants.js, mirage/factories/activity.js
Fixed typo in ActivityCategories: changed 'genootschapen' to 'genootschappen' in both the constants definition and mirage factory category array.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • ToMaarton
  • DrumsnChocolate

Poem

🐰 A typo hop, now fixed with care,
Genootschappen spelled just right, everywhere!
From constants down to factory floors,
Consistency opens many doors. ✨

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change in the PR: correcting the spelling of 'genootschapen' to 'genootschappen' across two files.
Description check ✅ Passed The description follows the template structure with Summary and Other information sections, though the Summary is minimal and could be more descriptive.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into staging

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/genootschapen-dyslexia

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 13.01%. Comparing base (bd515d5) to head (3a2ae1d).

Additional details and impacted files
@@           Coverage Diff            @@
##           staging    #1074   +/-   ##
========================================
  Coverage    13.01%   13.01%           
========================================
  Files          450      450           
  Lines         3127     3127           
========================================
  Hits           407      407           
  Misses        2720     2720           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant