-
Notifications
You must be signed in to change notification settings - Fork 118
1317 applicationservice fails to access applications inside private folders #1318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nicolasbisurgi
wants to merge
3
commits into
master
Choose a base branch
from
1317-applicationservice-fails-to-access-applications-inside-private-folders
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
1317 applicationservice fails to access applications inside private folders #1318
nicolasbisurgi
wants to merge
3
commits into
master
from
1317-applicationservice-fails-to-access-applications-inside-private-folders
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
…and discover() This PR fixes issue #1317 where ApplicationService failed to access applications inside private folders. Key changes: - Refactored _resolve_path() to properly handle mixed public/private folder hierarchies by probing path segments to find private boundaries - Added _build_path_url() to construct correct URLs with PrivateContents - Added _find_private_boundary() to detect where paths transition to private - Added discover() method for exploring the Applications folder tree - All application methods (get, get_document, exists, create, update, delete, rename) now correctly handle documents in private folders The TM1 REST API requires different URL patterns: - Public: /Contents('folder')/Contents('subfolder') - Private: /PrivateContents('folder')/PrivateContents('subfolder') - Mixed: /Contents('public')/PrivateContents('private') Once inside a private folder, all nested content must use PrivateContents.
Collaborator
Author
Summary
New Features
|
Contributor
|
Tests completed for environment: tm1-11-cloud. Check artifacts for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Summary
Problem
The ApplicationService failed with 404 errors when accessing applications inside private folders because the TM1 REST API requires PrivateContents('FolderName') for private folder segments, but TM1py was always using Contents('FolderName') for intermediate path segments.
Solution: Implemented automatic path resolution with an optimistic probing strategy:
Changes: