Marks and navigation buttons for chapters of video files in the player navigation #9924
Conversation
… task metadata rest api endpoint. Extends FramesMetaData class with video chapter information in the frontend.
* Seek to next/previous chapter mark
MhhhxX
requested review from
SpecLad,
bsekachev and
zhiltsov-max
as code owners
|
It seems chapter marker can overlap with frame name: |
@klakhov I could show the ticks above the slider like this: |
|
@MhhhxX, Yes, I think it would be better. |
… the marks to the front.
…ded will never be. Renamed end field of Chapter classes to stop to be consistent with the range spec of the CVAT project.
Co-authored-by: Maxim Zhiltsov <[email protected]>
…i. Update api schema.
Markers are now above the slider. |
|
@zhiltsov-max do you know why the consensus e2e test is failing now? The same test ran through before. |
|
Some tests can fail sporadically, need to restart a couple of times and check if it helps. We're working on this problem, but haven't fixed it completely yet. |
|
Please wait for #10056 to fix the issue with consensus tests. |
|
#10056 merged |
|
@MhhhxX, it seems there's some loop in the player navigation, could you please check it? |
|
This requires at least some basic e2e coverage |
The shortcut test failed locally for me because some of the existing shortcuts moved to a different page on the shortcut overview. I implemented a search function which navigates through all the pages and checks if the shortcut with the description exists on one of the pages. Actually I couldn't find a loop. The shortcut test now runs through on my machine. |
I implemented some frontend tests for chapters. |
| @@ -0,0 +1,101 @@ | |||
| context('Video chapters', () => { | |||
There was a problem hiding this comment.
| context('Video chapters', () => { | |
| // Copyright (C) CVAT.ai Corporation | |
| // | |
| // SPDX-License-Identifier: MIT | |
| context('Video chapters', () => { |
| } | ||
|
|
||
| cy.wrap($btn).click(); | ||
| cy.wait(500); |
There was a problem hiding this comment.
Arbitrary waiting is an anti-pattern. Please try to find a UI state to push off of or use a cy.intercept if there's a request
There was a problem hiding this comment.
Fixed. I wait for the active page class to appear on the new page.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #9924 +/- ##
===========================================
+ Coverage 75.09% 82.63% +7.53%
===========================================
Files 428 484 +56
Lines 46254 49435 +3181
Branches 4139 4143 +4
===========================================
+ Hits 34734 40850 +6116
+ Misses 11520 8585 -2935
🚀 New features to boost your workflow:
|
|
6 participants
Motivation and context
Searching for relevant frames to annotate in freshly uploaded and especially long videos can be very time consuming without any kind of hint.
To give a help for the worker who annotates the video this PR uses the chapter marks stored inside the metadata of
some video container formats. Chapter marks are shown as clickable ticks underneath the player slider and there are new player buttons to jump the previous/next chapter in the video. A worker can use these navigation features on newly uploaded videos and (immediately) start annotating on relevant frames.
Example:
How has this been tested?
I extended the rest api test case for TaskMetaData
e2e test cases
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.