-
Notifications
You must be signed in to change notification settings - Fork 3.5k
relaxing manifest creation #9994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #9994 +/- ##
===========================================
- Coverage 82.58% 73.89% -8.69%
===========================================
Files 484 428 -56
Lines 49339 46249 -3090
Branches 4134 4134
===========================================
- Hits 40745 34175 -6570
- Misses 8594 12074 +3480
🚀 New features to boost your workflow:
|
SpecLad
reviewed
Nov 14, 2025
Contributor
|
Please add a changelog entry. |
Contributor
Author
done |
|
SpecLad
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Motivation and context
After update of ffmpeg, for some videos, when seeking to a keyframe, seek lands on a previous keyframe.
With our current way of creating manifest, for such videos the manifest is empty.
It is not optimal: it is a lot better to be able to seek to 1000th keyframe of some video and land on 999th keyframe and decode to 1000th, than to decode all the way from video beginning.
Relaxing manifest creation for such cases.
How has this been tested?
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.