Skip to content

Conversation

@Eldies
Copy link
Contributor

@Eldies Eldies commented Nov 10, 2025

Motivation and context

After update of ffmpeg, for some videos, when seeking to a keyframe, seek lands on a previous keyframe.

With our current way of creating manifest, for such videos the manifest is empty.
It is not optimal: it is a lot better to be able to seek to 1000th keyframe of some video and land on 999th keyframe and decode to 1000th, than to decode all the way from video beginning.

Relaxing manifest creation for such cases.

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@Eldies Eldies requested a review from SpecLad as a code owner November 10, 2025 12:28
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.89%. Comparing base (56a4d22) to head (d61b663).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9994      +/-   ##
===========================================
- Coverage    82.58%   73.89%   -8.69%     
===========================================
  Files          484      428      -56     
  Lines        49339    46249    -3090     
  Branches      4134     4134              
===========================================
- Hits         40745    34175    -6570     
- Misses        8594    12074    +3480     
Components Coverage Δ
cvat-ui 77.62% <ø> (+0.12%) ⬆️
cvat-server 70.73% <83.33%> (-15.68%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SpecLad
Copy link
Contributor

SpecLad commented Nov 27, 2025

Please add a changelog entry.

@Eldies Eldies requested a review from nmanovic as a code owner November 28, 2025 10:34
@Eldies
Copy link
Contributor Author

Eldies commented Nov 28, 2025

Please add a changelog entry.

done

@sonarqubecloud
Copy link

@SpecLad SpecLad merged commit 7a1b431 into develop Nov 28, 2025
40 checks passed
@SpecLad SpecLad deleted the dl/relax-manifest-creation branch November 28, 2025 11:13
@cvat-bot cvat-bot bot mentioned this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants