Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps
wgpufrom 29 to 30.The only code change required was in
FsrPass::new: thenum_workgroupsfield of
ShaderModuleDescriptorPassthroughwas removed in wgpu 30 andreplaced with
entry_points. Since SPIR-V shaders don't use theworkgroup_sizevalue, we pass(1, 1, 1).Verified with:
cargo clippycargo doccargo deny checkcargo test -p wgpu-ffx: bothfsr_smokeandfsr_dispatch_smokepassRelated Issues
Closes #23