Fix NullReferenceException in DidSelectFunctionalUnit on macOS#832
Open
pike00 wants to merge 1 commit into
Open
Fix NullReferenceException in DidSelectFunctionalUnit on macOS#832pike00 wants to merge 1 commit into
pike00 wants to merge 1 commit into
Conversation
ImageCaptureCore may invoke didSelectFunctionalUnit:error: with a null functionalUnit; the debug log line dereferenced it unconditionally and crashed. Null-guard the log and fall back to SelectedFunctionalUnit. Fixes cyanfish#831.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #831.
Problem
DeviceOperator.DidSelectFunctionalUnitdereferencesfunctionalUnitunconditionally in its debug log line. ImageCaptureCore may invokedidSelectFunctionalUnit:error:with a nullfunctionalUnit, sofunctionalUnit.GetType().NamethrowsNullReferenceExceptionand scanning crashes (full trace in #831).Change
_device.SelectedFunctionalUnitwhen the callback hands back a null unit, so the null does not propagate intoSelectUnit/Scan.Testing
NAPS2.Sdkbuilds cleanly fornet8-macos(the TFM that compiles this file).NAPS2.App.Macbuilds and launches.??only activates when the value is already null, so it cannot change the existing non-null path.🤖 Generated with Claude Code