Skip to content

Conversation

@MikeMcC399
Copy link
Collaborator

Situation

There are 2 issues with [email protected]:

  1. npm audit and Dependabot report a medium severity vulnerability CVE-2025-56200 in [email protected] which is a transient dependency of [email protected]

  2. it reports success even if there were link errors

Change

Remove and re-install markdown-link-check to update to [email protected] (current latest)

npm uninstall markdown-link-check
npm install markdown-link-check -D

Verification

Ubuntu 24.04.3 LTS, Node.js 22.19.0 LTS

npm ci
npm audit

verify output to be:

found 0 vulnerabilities

Then execute:

npm run check:markdown

and confirm no bad links reported.

Finally, execute the following check to simulate a bad link:

cat > missing.md <<EOT
[bad link](https://github.com/cypress-io/cypress-docker-images/missing.md)
EOT
npm run check:markdown
echo "exit status should be non-zero for failure: " $?
rm missing.md

@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 added the bug label Nov 10, 2025
@MikeMcC399 MikeMcC399 self-assigned this Nov 10, 2025
@MikeMcC399 MikeMcC399 marked this pull request as ready for review November 10, 2025 09:07
@jennifer-shehane jennifer-shehane merged commit df0ec19 into cypress-io:master Nov 11, 2025
51 checks passed
@MikeMcC399 MikeMcC399 deleted the update/markdown-link-check branch November 11, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants