Repository navigation
CORE-2205: add a batch update endpoint to allow CPU & GPU to be updated at once - #44
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Member
Author
|
Thanks! My view hadn't shown your review when I requested one earlier, sorry about that. I'll merge this once the resource-usage-api changes that depend on it are ready to merge as well, I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Realized this would be necessary while reviewing my resource-usage-api changes; otherwise you get annoying concurrency stuff like a failed GPU update leading to double-counted CPU or vice versa. This instead pushes the transaction into this service so the updates are tied to one another.