Skip to content

pool: Improve logging for hot file replication #8061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mksahakyan merged 1 commit into from
Apr 2, 2026
+6 −2
Merged

pool: Improve logging for hot file replication #8061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions modules/dcache/src/main/java/org/dcache/pool/classic/PoolV4.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,8 +752,9 @@ private int queueIoRequest(CellMessage envelope, PoolIoFileMessage message)
private void ioFile(CellMessage envelope, PoolIoFileMessage message) {
try {
message.setMoverId(queueIoRequest(envelope, message));
LOGGER.debug("moverId {} received request for pnfsId {}", message.getMoverId(),
message.getPnfsId());
LOGGER.debug("moverId {} received request for pnfsId {}, hotfile replication is {}",
message.getMoverId(), message.getPnfsId(), _hotFileReplicationEnabled
? "enabled" : "disabled");
if (_hotFileReplicationEnabled) {
_fileRequestMonitor.reportFileRequest(message.getPnfsId(),
_ioQueue.numberOfRequestsFor(message.getPnfsId()),
Expand Down
3 changes: 3 additions & 0 deletions modules/dcache/src/main/java/org/dcache/pool/migration/MigrationModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1252,12 +1252,15 @@ public Object messageArrived(CellMessage envelope, PoolMigrationJobCancelMessage
public synchronized void reportFileRequest(PnfsId pnfsId, long numberOfRequests,
ProtocolInfo protocolInfo) {
if (numberOfRequests < hotFileThreshold) {
LOGGER.debug("hotfile replication : conditions not satisfied numberOfRequests {} < hotFileThreshold {}",
numberOfRequests, hotFileThreshold);
return;
}
String jobId = "hotfile-" + pnfsId;
try {
Job job = _jobs.get(jobId);
if (job != null) {
LOGGER.debug("hotfile replication : found job with jobid {} in state {}", jobId, job.getState());
Comment on lines +1255 to +1263
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new debug message is hard to correlate with a specific request because it omits the pnfsId (and has slightly awkward formatting with a space before the colon). Consider including pnfsId in the log fields and using a consistent prefix like "hotfile replication:" to make this line more actionable when debugging.

Suggested change
LOGGER.debug("hotfile replication : conditions not satisfied numberOfRequests {} < hotFileThreshold {}",
numberOfRequests, hotFileThreshold);
return;
}
String jobId = "hotfile-" + pnfsId;
try {
Job job = _jobs.get(jobId);
if (job != null) {
LOGGER.debug("hotfile replication : found job with jobid {} in state {}", jobId, job.getState());
LOGGER.debug("hotfile replication: conditions not satisfied for pnfsId {}: numberOfRequests {} < hotFileThreshold {}",
pnfsId, numberOfRequests, hotFileThreshold);
return;
}
String jobId = "hotfile-" + pnfsId;
try {
Job job = _jobs.get(jobId);
if (job != null) {
LOGGER.debug("hotfile replication: found job for pnfsId {} with jobid {} in state {}", pnfsId, jobId, job.getState());

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor log-text issue: "jobid" is inconsistent with typical camelCase naming ("jobId"), and the "hotfile replication :" prefix has a space before the colon. Tweaking the message wording would improve readability/searchability in logs.

Copilot uses AI. Check for mistakes.
switch (job.getState()) {
case FINISHED:
case CANCELLED:
Expand Down
Loading