Initial MCP Roots support #211
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Connor Braa <[email protected]>
cwlbraa
changed the title
aluzzardi
reviewed
Jul 10, 2025
Contributor
aluzzardi
left a comment
aluzzardi
left a comment
There was a problem hiding this comment.
Looks good, left minor nits
Signed-off-by: Connor Braa <[email protected]>
Contributor
Author
|
tested this with vscode and i can't get to the error path at all because agent mode auto-injects the root dirs into the context, so this may be useless for right now. |
aluzzardi
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
impl is as minimal as possible. tested via
echo {json} | timeout 5 cu stdio, still need to test with actual vscode.currently only used to facilitate better error messages on repo.Open, but with dynamic tools we can also use the roots to provide better tool descriptions.