Repository navigation
Refuse watch mode when stdout is not a terminal - #984
Open
Saadanjum0 wants to merge 1 commit into
Open
Saadanjum0 wants to merge 1 commit into
Saadanjum0 wants to merge 1 commit into
Conversation
Previously 'procs -w | cat' streamed ANSI screen frames into the pipe forever. Now it exits with an error, like top and watch do. Plain output piping is unchanged. Refs dalance#982.
Saadanjum0
force-pushed
the
fix/watch-requires-tty
branch
from
October 9, 2026 07:00
818ad5a to
6c1da28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
procs -w | cat(or> file) enters the interactive watch TUI and writes ANSI frames into the pipe forever (see #982).Cause
run_watchnever checks that stdout is a terminal.Fix
Bail with
--watch requires a terminal, but stdout is not a TTYbefore starting the watcher. Non-watch piping (procs | cat) is unaffected.Testing
test_watch_requires_tty;cargo testpasses (19 tests).procs -w | headandprocs -w </dev/null | catnow print the error and exit.