Added element input to eos helmholtz with default being C/O 50,50. #822
Conversation
…w it should be added as a runtime parameter in .in files when eos is helmholtz
There was a problem hiding this comment.
Code Review
This pull request updates the Helmholtz Equation of State (EOS) module to allow runtime configuration of species mass fractions (hydrogen, helium, carbon, oxygen, neon, and magnesium) instead of using hard-coded values. Feedback on these changes highlights a critical issue where using tiny(xmass) as a tolerance for the mass fraction sum check will fail due to floating-point precision limits; using epsilon or a reasonable tolerance is recommended. Additionally, the new configuration parameters should include default values in read_inopt to maintain backward compatibility with existing input files, and commented-out dead code should be cleaned up.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
the test failure is the same one we had on Antoine's pull request, seems a bit stochastic but likely related to previous changes. I suspect the temp(:) array we added needs to be at least allocated/initialised to zero for the non-Helmholtz cases |
|
I added a line in |
Description:
The element abundance in EOS helmholtz was hardcoded before; now elements H,He,C,O,Ne,Mg can be added as a runtime parameter in .in files when eos is helmholtz
Components modified:
Type of change:
Testing:
setting the total elements to more than 1 and seeing if it gives errors
Did you run the bots? no
Did you add comments such that the purpose of the code is understandable? yes/