Fix step_trait on recent nightly: implement forward/backward_overflowing - #112
Conversation
|
thank you! I'll upload a patch to fix the check documentation error shortly - we can ignore that one. for the semantic versioning failure we probably have to update the compiler that's being used to perform the check? |
|
doc fix: #112 |
|
let me know if you'd like to fix the semantic version issue yourself - if not, I'm happy to take over this patch |
|
I quickly ran 2 tests when I saw the failure with the 2 solutions I could think of:
You can take over this patch and decide what's best. Or if you want me to push one of the above solutions to this PR's branch, let me know. |
The new Step::forward_overflowing/backward_overflowing impls only exist on recent nightly, so the crate no longer compiles with step_trait on the stable toolchain cargo-semver-checks runs on. Semver-checking an unstable, nightly-gated feature has little value anyway.
Context
rust-lang/rust#155114 added two required methods to
Steptrait, so--features step_traitno longer builds on current nightly.Change
forward_overflowing/backward_overflowing. These wrap via the underlying type's*_overflowingplusmasked_new. That's what the trait docs recommend.AI disclosure: Claude Code wrote the tests and changelog entry.