update passthrough for SVG to match asset location#15
Open
twigley wants to merge 1 commit intodanurbanowicz:mainfrom
Open
update passthrough for SVG to match asset location#15twigley wants to merge 1 commit intodanurbanowicz:mainfrom
twigley wants to merge 1 commit intodanurbanowicz:mainfrom
Conversation
Owner
|
Thanks @twigley for flagging this! Can you confirm that the icon correctly loads in your PR? I seem to remember Tina CMS needing a path relative to the repo root rather than the build root. Not sure though! |
Author
Ah sorry I've not been able to test as I'm using it standalone without the CMS :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like this might have been missed from #7 as the svg icon is missing in Firefox on main, this sorts the passthrough so the svg favicon exists under /_site