Fix partial macOS defaults tracking#410
Closed
cursor[bot] wants to merge 1 commit into
Closed
Conversation
Co-authored-by: cooper <czxtm@users.noreply.github.com>
Contributor
📋 PR Overview
🔬 Coverage
|
Contributor
🎨 Storybook previewUpdated for 0586281 ❌ Failed snapshots (2)These stories' HTML snapshots changed. Update snapshots ↗ to regenerate baselines and open a PR: Settings/AutoConfigField › ControlsSettings/AutoTuningSection › Evolution Settings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a critical partial-tracking bug in the macOS defaults filesystem view.
When a user tracked only one untracked macOS default, the backend wrote
modules/darwin/system-defaults.nixwith just that selected item. Future scans then returned an empty result solely because the file existed, hiding all remaining untracked defaults and making them effectively untrackable from the UI.This PR:
system-defaults.nixexists and filters out only defaults already present in the module.system-defaults.nixinstead of overwriting it.Test Plan
cargo +stable test --manifest-path apps/native/src-tauri/Cargo.toml system_defaultsDocs