Repository navigation
Use install_steps for the Homebrew cask quarantine hook - #411
Open
vladosskins178 wants to merge 1 commit into
Open
vladosskins178 wants to merge 1 commit into
vladosskins178 wants to merge 1 commit into
Conversation
Homebrew deprecated the postflight stanza, so installing posting@beta prints a deprecation warning. GoReleaser's install_steps writes postflight_steps instead. Fixes darrenburns#409
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #409
Homebrew 7.0.4 deprecated the cask
postflightblock in favour ofpostflight_steps, so installing or upgradingposting@betaprints:The cask is generated, so this changes
.goreleaser.yaml:hooks.post.installbecomeshooks.post.install_steps(GoReleaser v2.19+, the release workflow uses~> v2). The new block uses Homebrew's install steps DSL instead of Ruby, soif OS.mac?becomeson_macos,system_commandbecomesrun, and#{staged_path}becomes{{ .StagedPath }}. This follows GoReleaser's own deprecation notice for this option.Generated cask, before and after:
What I checked:
goreleaser checkandgoreleaser release --snapshot --clean --skip=publishwith GoReleaser 2.20.0: thehomebrew_casks.hooks.post.installdeprecation notice is gone and the cask above is written.homebrew/brewimage, archive URLs pointed at the localdist/). Before: the deprecation warning above, andbrew stylereportsCask/InstallSteps: Casks must use postflight_steps instead of postflight. After: no warning,posting --versionworks, and thatbrew styleoffense is gone. (The otherbrew styleoffenses, like the homepage slash, are there before and after.)Not checked: the
xattrstep itself on macOS. I have no Mac here, and on Linuxon_macosskips it.