Stabilize release tests on current Go toolchains - #171
Merged
Merged
Conversation
Co-authored-by: Darron Froese <darron@froese.org> Signed-off-by: Darron Froese <darron@froese.org>
PR Diff StatsPR #171 changed 4 file(s), with +21 / -3 (24 changed lines).
Largest Changed Files
Bucket rules
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
github.com/go-json-experiment/jsonto a revision compatible with the JSON v2 APIs exposed by Go 1.27 (json.SkipFuncandjson.DiscardUnknownMembers).Why
The release test intermittently failed because the first admission-pool connection could take just over the test's 200 ms timing threshold while an unrelated semantic lease was held. Separately, local Go 1.27 builds failed before tests compiled because the old indirect JSON module referenced standard-library APIs that are no longer present under that toolchain.
Verification
go test -race ./internal/store -run '^TestLinkCaptureQueueDoesNotWaitForSemanticLease$' -count=100go test -race ./internal/store -count=1go test -mod=readonly -race ./internal/store ./internal/mediadownload -count=1task test-ciunder Go 1.27.00 issuesThe release retry also completed the Verify job and the linux/amd64, linux/arm64, darwin/amd64, and windows/amd64 builds successfully while this PR was prepared; the native darwin/arm64 build was still running at the last check.