Skip to content

Conversation

@parlough
Copy link
Member

Fixes #7017

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @parlough, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where intermediate Markdown output files were inadvertently included in the sitemap for the dart.dev website. The change introduces a new exclusion rule in the site build configuration, ensuring that only relevant, public-facing content is listed in the sitemap, thereby improving its accuracy and utility.

Highlights

  • Sitemap Generation: The site build command has been updated to explicitly exclude secondary Markdown output files from the sitemap. This prevents files with the .html.md extension from being included in the dart.dev sitemap.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly excludes secondary Markdown output files from the sitemap by adding the --sitemap-exclude argument to the build command. The implementation is straightforward and correct. My review includes one suggestion to improve code maintainability by replacing the hardcoded argument string with a named constant.

@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Nov 13, 2025

Visit the preview URL for this PR (updated for commit ccb364e):

https://dart-dev--pr7018-fix-7017-lai86363.web.app

@parlough parlough requested a review from antfitch November 14, 2025 16:56
@parlough parlough merged commit 418ef89 into main Nov 18, 2025
11 checks passed
@parlough parlough deleted the fix/7017 branch November 18, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Markdown files can included in search

3 participants