Skip to content

Conversation

@connie-ooi
Copy link
Contributor

@connie-ooi connie-ooi commented Nov 14, 2025

Add Analyzer performance page.

Resolves #6924

@connie-ooi connie-ooi self-assigned this Nov 14, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @connie-ooi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a comprehensive guide to help users diagnose and resolve performance issues with the Dart analysis server. It aims to improve the developer experience by offering solutions to common problems and providing clear steps for reporting more complex issues, ensuring that users can efficiently troubleshoot their development environments.

Highlights

  • New Documentation Page: A new page titled 'Troubleshoot Analyzer Performance' has been added to provide guidance on diagnosing and resolving common Dart analysis server performance issues.
  • Known Performance Issues: The new page details common performance bottlenecks, including the impact of security software on Windows systems and issues related to symbolic links in package directories.
  • Reporting Unknown Issues: Instructions are provided on how to effectively report unknown performance problems to the Dart SDK issue tracker, emphasizing the importance of reproduction steps, performance data collection, and instrumentation logs.
  • Navigation Integration: The new 'Troubleshoot Analyzer Performance' page has been integrated into the site's sidebar navigation under the 'Tools' section.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new documentation page for troubleshooting Dart analyzer performance, which is a valuable addition. The content is clear and helpful. My review focuses on several formatting issues in the new markdown file, primarily related to adhering to the 80-character line limit specified in the contribution guidelines. I've provided specific suggestions to resolve these style guide violations.

connie-ooi and others added 2 commits November 14, 2025 15:30
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@dart-github-bot
Copy link
Collaborator

dart-github-bot commented Nov 14, 2025

Visit the preview URL for this PR (updated for commit 6c26b36):

https://dart-dev--pr7020-analyzer-performance-0mqpdan0.web.app

connie-ooi and others added 3 commits November 14, 2025 15:30
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link
Member

@bwilkerson bwilkerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks!

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great to me. We've needed this for a while, so thanks for tackling it!

Do wait for a copy review from @antfitch.

connie-ooi and others added 14 commits November 17, 2025 11:58
@parlough
Copy link
Member

Thanks for making those adjustments, still looks good to me!

A question though. Should we link to this from the https://dart.dev/tools/analysis page for more discoverability? At least in the end Resources section but perhaps as a note somewhere else as well.

@connie-ooi
Copy link
Contributor Author

@parlough Yeah! I can definitely add it to that page.

Copy link
Collaborator

@antfitch antfitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Small style changes.

* If you can't share your code, create a small, self-contained reproduction case.
* If you can't provide either, please state that in the issue.

### Provide performance data
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's follow the Google Developer Style guide for procedures: https://developers.google.com/style/procedures

If you have any questions, ping me!

Copy link
Collaborator

@antfitch antfitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@connie-ooi connie-ooi merged commit 047b191 into dart-lang:main Nov 19, 2025
11 checks passed
@connie-ooi connie-ooi deleted the analyzer-performance branch November 19, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add information on Windows Defender slowing down development

5 participants