collision: fix Bullet double-precision includes (6.16) #2334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2332.
Background
When Bullet is built with double precision (
BT_USE_DOUBLE_PRECISION=1), DART 6.16 can violate the ODR becausedart/collision/bullet/BulletTypes.hppincluded Bullet headers directly, bypassingdart/collision/bullet/BulletInclude.hpp(which includesdart/config.hppfirst). This shows up as-Wodrwarnings and runtime failures (raycast returns no hits and then segfaults; Bullet-based collision regression tests fail).Changes
dart/collision/bullet/BulletTypes.hpp: include Bullet viadart/collision/bullet/BulletInclude.hppto ensure consistent Bullet precision macros across all translation units.tests/integration/test_Raycast.cpp: useASSERT_*before indexingmRayHits(avoids segfault when a hit is unexpectedly missing).Local verification
ctest -R '^(test_Raycast|test_Collision|test_ForceDependentSlip|test_Issue1184)$'.CMAKE_BUILD_PARALLEL_LEVEL=16 CTEST_PARALLEL_LEVEL=16 pixi run test,CMAKE_BUILD_PARALLEL_LEVEL=16 pixi run test-all, andCMAKE_BUILD_PARALLEL_LEVEL=16 pixi run -e gazebo test-gz.