fix: ip addresses + some cleanup + add some mn bindings#113
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Syn-McJ
left a comment
There was a problem hiding this comment.
Looks good, although I still can't build with build.sh:
error[E0107]: struct takes 3 generic arguments but 2 generic arguments were supplied
--> /Users/andrei/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tower-0.4.13/src/ready_cache/cache.rs:73:12
|
73 | ready: IndexMap<K, (S, CancelPair)>,
| ^^^^^^^^ - --------------- supplied 2 generic arguments
| |
| expected 3 generic arguments
|
note: struct defined here, with 3 generic parameters: `K`, `V`, `S`
This pull request updates the
dash-spv-apple-bindingsproject by modernizing dependencies, improving compatibility, and simplifying the codebase. Key changes include dependency upgrades, feature enhancements, and the removal of unused or redundant code.Dependency Updates and Feature Enhancements:
Cargo.toml, includinganyhow,indexmap, andfermentto newer versions for better compatibility and stability. Thegrovedb-versiondependency now points to a specific Git revision. Added new features likemessage_verificationandquorum_validationto the default feature set. [1] [2] [3] [4]Cargo.tomlfor better alignment with modern iOS versions.Code Simplifications:
FFICoreProviderinffi_core_provider.rs, such asget_cl_signature_by_block_hashandnotify_sync_state. Simplified the implementation ofMasternodeProcessorinitialization. [1] [2] [3] [4]lib.rs, including the removal of theDiffConfigstruct and unused error types. [1] [2] [3] [4] [5]Build and Configuration Improvements:
build.shto fix paths for verification scripts and commented out logging configuration forRUSTC_LOG. [1] [2]quorum_validation) incbindgen.tomlfor code generation. Removed outdated and unused configuration options.Test Code Cleanup:
get_block_from_insight_by_hashandregister_logger, fromcommon.rsto streamline the test codebase. [1] [2]Miscellaneous:
cbindgencrate frombuild.rsas it is no longer used.