backport: Merge bitcoin#29404, 28144, 28118 by vijaydasmp · Pull Request #7124 · dashpay/dash

vijaydasmp · 2026-02-02T11:33:01Z

bitcoin backporting
🤕➡️🛌🩹➡️💪⚡💻🔙

github-actions · 2026-02-02T11:33:59Z

⚠️ Potential Merge Conflicts Detected

This PR has potential conflicts with the following open PRs:

feat!: migrate additional indexes from synchronous to async operation #7101 - feat!: migrate additional indexes from synchronous to async operation

Please coordinate with the authors of these PRs to avoid merge conflicts.

github-actions · 2026-02-15T21:59:35Z

This pull request has conflicts, please rebase.

github-actions · 2026-02-17T01:07:57Z

This pull request has conflicts, please rebase.

coderabbitai · 2026-02-26T11:32:34Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a7bdcc8f-ccd1-40fc-8437-a5becc0b2ad9

📥 Commits

Reviewing files that changed from the base of the PR and between 10a457b and ae9e403.

📒 Files selected for processing (56)

src/addrdb.cpp
src/addrman.cpp
src/bench/verify_script.cpp
src/bench/wallet_create.cpp
src/bench/wallet_loading.cpp
src/clientversion.cpp
src/compat/compat.h
src/crypto/chacha20poly1305.cpp
src/crypto/muhash.h
src/crypto/sha256.cpp
src/netaddress.h
src/netbase.h
src/qt/addressbookpage.cpp
src/qt/askpassphrasedialog.cpp
src/qt/bitcoingui.cpp
src/qt/coincontroldialog.cpp
src/qt/guiutil.cpp
src/qt/modaloverlay.cpp
src/qt/notificator.cpp
src/qt/paymentserver.cpp
src/qt/paymentserver.h
src/qt/sendcoinsentry.cpp
src/qt/sendcoinsrecipient.h
src/qt/test/apptests.cpp
src/qt/test/optiontests.cpp
src/qt/transactiondesc.cpp
src/qt/walletmodel.cpp
src/qt/walletmodel.h
src/qt/walletmodeltransaction.cpp
src/random.cpp
src/rest.cpp
src/rpc/external_signer.cpp
src/rpc/mining.cpp
src/rpc/node.cpp
src/rpc/register.h
src/rpc/server.cpp
src/rpc/util.cpp
src/serialize.h
src/support/lockedpool.cpp
src/sync.cpp
src/test/script_tests.cpp
src/test/system_tests.cpp
src/test/util/setup_common.cpp
src/validation.cpp
src/validation.h
src/wallet/init.cpp
src/wallet/rpc/addresses.cpp
src/wallet/rpc/backup.cpp
src/wallet/rpc/wallet.cpp
src/wallet/sqlite.cpp
src/wallet/test/db_tests.cpp
src/wallet/test/util.h
src/wallet/walletdb.cpp
src/warnings.cpp
test/functional/p2p_getaddr_caching.py
test/functional/test_framework/test_node.py

💤 Files with no reviewable changes (19)

src/sync.cpp
src/qt/test/apptests.cpp
src/qt/transactiondesc.cpp
src/qt/paymentserver.h
src/qt/walletmodeltransaction.cpp
src/qt/walletmodel.h
src/qt/paymentserver.cpp
src/compat/compat.h
src/qt/walletmodel.cpp
src/qt/sendcoinsrecipient.h
src/qt/addressbookpage.cpp
src/qt/coincontroldialog.cpp
src/crypto/muhash.h
src/support/lockedpool.cpp
src/netbase.h
src/qt/askpassphrasedialog.cpp
src/netaddress.h
src/qt/sendcoinsentry.cpp
src/validation.h

✅ Files skipped from review due to trivial changes (29)

src/rest.cpp
src/rpc/register.h
src/bench/verify_script.cpp
src/bench/wallet_create.cpp
src/addrdb.cpp
src/clientversion.cpp
src/crypto/chacha20poly1305.cpp
src/bench/wallet_loading.cpp
src/rpc/external_signer.cpp
src/qt/modaloverlay.cpp
src/rpc/util.cpp
src/crypto/sha256.cpp
src/qt/guiutil.cpp
src/wallet/init.cpp
src/test/util/setup_common.cpp
src/qt/test/optiontests.cpp
src/wallet/sqlite.cpp
src/wallet/test/util.h
src/rpc/server.cpp
src/random.cpp
src/warnings.cpp
src/addrman.cpp
src/wallet/rpc/addresses.cpp
src/rpc/mining.cpp
src/serialize.h
src/qt/bitcoingui.cpp
src/wallet/rpc/wallet.cpp
src/test/script_tests.cpp
src/wallet/rpc/backup.cpp

🚧 Files skipped from review as they are similar to previous changes (6)

src/qt/notificator.cpp
src/test/system_tests.cpp
src/wallet/test/db_tests.cpp
test/functional/test_framework/test_node.py
src/rpc/node.cpp
test/functional/p2p_getaddr_caching.py

Walkthrough

The diff mainly standardizes conditional inclusion of <config/bitcoin-config.h> across many source files (guarded by HAVE_CONFIG_H) and removes it from several headers. Most edits are compile-time include adjustments with no behavioral changes. Functional changes occur in src/rpc/node.cpp: RPC handlers now obtain a required NodeContext via EnsureAnyNodeContext(request.context), iterate chain_clients to call setMockTime(time), call the scheduler's MockForward(...) via a checked scheduler reference, and call SyncWithValidationInterfaceQueue(); test/P2P utilities also have minor peer-selection and addr-message handling updates.

Sequence Diagram(s)

mermaid
sequenceDiagram
participant RPC_Client
participant RPC_Handler as RPC Handler
participant NodeContext as NodeContext
participant ChainClients as ChainClients[*]
RPC_Client->>RPC_Handler: send "setmocktime" request
RPC_Handler->>NodeContext: EnsureAnyNodeContext(request.context)
Note right of NodeContext: returns const NodeContext&
RPC_Handler->>ChainClients: for each chain_client -> setMockTime(time)
ChainClients-->>RPC_Handler: ack
RPC_Handler-->>RPC_Client: return result

mermaid
sequenceDiagram
participant RPC_Client
participant RPC_Handler as RPC Handler
participant NodeContext as NodeContext
participant Scheduler as Scheduler
participant ValIntQueue as ValidationInterfaceQueue
RPC_Client->>RPC_Handler: send "mockscheduler" request
RPC_Handler->>NodeContext: EnsureAnyNodeContext(request.context)
RPC_Handler->>Scheduler: CHECK_NONFATAL(...)->MockForward(delta)
Scheduler-->>RPC_Handler: ack
RPC_Handler->>ValIntQueue: SyncWithValidationInterfaceQueue()
ValIntQueue-->>RPC_Handler: synced
RPC_Handler-->>RPC_Client: return result

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'backport: Merge bitcoin#29404, 28144, 28118' clearly and specifically identifies the main change—backporting three Bitcoin upstream PRs into the Dash codebase.
Description check	✅ Passed	The description mentions 'bitcoin backporting' which is directly related to the changeset. While minimal, it contextually aligns with the backport work shown in the commit messages and file summaries.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

src/rpc/node.cpp (1)
7-11: Include order: config/bitcoin-config.h should be included before other headers.

The config header defines macros (e.g., HAVE_MALLOC_INFO used on line 43) that may affect how subsequent headers behave. Placing the config include after <addressindex.h> violates the standard pattern where config headers come first.
Suggested fix
+#if defined(HAVE_CONFIG_H)
+#include <config/bitcoin-config.h>
+#endif
+
 `#include` <addressindex.h>
-#if defined(HAVE_CONFIG_H)
-#include <config/bitcoin-config.h>
-#endif
-
 `#include` <chainparams.h>
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/rpc/node.cpp` around lines 7 - 11, Move the config include so it appears
before any other headers: place `#if` defined(HAVE_CONFIG_H) / `#include`
<config/bitcoin-config.h> at the top of src/rpc/node.cpp (above `#include`
<addressindex.h>) so macros like HAVE_MALLOC_INFO are defined before other
headers are processed; update the include block around the existing preprocessor
directives accordingly to ensure config is included first.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@test/functional/test_framework/test_node.py`:
- Line 723: The peer matching assumes addrbind is always present and can raise
KeyError; update the filter in test_node.py where getpeerinfo() is iterated (the
list comprehension that builds info) to safely handle missing addrbind by using
peer.get("addrbind") (or "in" check) when comparing to dst_addr_and_port, so
replace peer["addrbind"] == dst_addr_and_port with a safe check such as
peer.get("addrbind") == dst_addr_and_port to avoid KeyError for peers without
addrbind while still matching addr and addrbind correctly for our_addr_and_port
and dst_addr_and_port.

---

Nitpick comments:
In `@src/rpc/node.cpp`:
- Around line 7-11: Move the config include so it appears before any other
headers: place `#if` defined(HAVE_CONFIG_H) / `#include` <config/bitcoin-config.h>
at the top of src/rpc/node.cpp (above `#include` <addressindex.h>) so macros like
HAVE_MALLOC_INFO are defined before other headers are processed; update the
include block around the existing preprocessor directives accordingly to ensure
config is included first.

ℹ️ Review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2cd9132 and 10a457b.

📒 Files selected for processing (56)

src/addrdb.cpp
src/addrman.cpp
src/bench/verify_script.cpp
src/bench/wallet_create.cpp
src/bench/wallet_loading.cpp
src/clientversion.cpp
src/compat/compat.h
src/crypto/chacha20poly1305.cpp
src/crypto/muhash.h
src/crypto/sha256.cpp
src/netaddress.h
src/netbase.h
src/qt/addressbookpage.cpp
src/qt/askpassphrasedialog.cpp
src/qt/bitcoingui.cpp
src/qt/coincontroldialog.cpp
src/qt/guiutil.cpp
src/qt/modaloverlay.cpp
src/qt/notificator.cpp
src/qt/paymentserver.cpp
src/qt/paymentserver.h
src/qt/sendcoinsentry.cpp
src/qt/sendcoinsrecipient.h
src/qt/test/apptests.cpp
src/qt/test/optiontests.cpp
src/qt/transactiondesc.cpp
src/qt/walletmodel.cpp
src/qt/walletmodel.h
src/qt/walletmodeltransaction.cpp
src/random.cpp
src/rest.cpp
src/rpc/external_signer.cpp
src/rpc/mining.cpp
src/rpc/node.cpp
src/rpc/register.h
src/rpc/server.cpp
src/rpc/util.cpp
src/serialize.h
src/support/lockedpool.cpp
src/sync.cpp
src/test/script_tests.cpp
src/test/system_tests.cpp
src/test/util/setup_common.cpp
src/validation.cpp
src/validation.h
src/wallet/init.cpp
src/wallet/rpc/addresses.cpp
src/wallet/rpc/backup.cpp
src/wallet/rpc/wallet.cpp
src/wallet/sqlite.cpp
src/wallet/test/db_tests.cpp
src/wallet/test/util.h
src/wallet/walletdb.cpp
src/warnings.cpp
test/functional/p2p_getaddr_caching.py
test/functional/test_framework/test_node.py

💤 Files with no reviewable changes (19)

src/netaddress.h
src/qt/sendcoinsentry.cpp
src/validation.h
src/support/lockedpool.cpp
src/qt/sendcoinsrecipient.h
src/qt/addressbookpage.cpp
src/qt/transactiondesc.cpp
src/qt/paymentserver.cpp
src/crypto/muhash.h
src/netbase.h
src/qt/walletmodel.h
src/qt/askpassphrasedialog.cpp
src/qt/test/apptests.cpp
src/qt/walletmodeltransaction.cpp
src/sync.cpp
src/qt/walletmodel.cpp
src/qt/paymentserver.h
src/qt/coincontroldialog.cpp
src/compat/compat.h

🚧 Files skipped from review as they are similar to previous changes (23)

src/wallet/test/util.h
src/random.cpp
src/serialize.h
src/wallet/rpc/addresses.cpp
src/bench/wallet_loading.cpp
src/wallet/rpc/wallet.cpp
src/rpc/mining.cpp
src/wallet/sqlite.cpp
src/bench/verify_script.cpp
src/wallet/init.cpp
src/qt/modaloverlay.cpp
src/rest.cpp
src/test/system_tests.cpp
src/test/script_tests.cpp
src/qt/guiutil.cpp
src/qt/notificator.cpp
src/addrdb.cpp
src/crypto/sha256.cpp
src/wallet/rpc/backup.cpp
src/rpc/server.cpp
src/rpc/external_signer.cpp
test/functional/p2p_getaddr_caching.py
src/crypto/chacha20poly1305.cpp

coderabbitai · 2026-03-04T00:01:34Z

test/functional/test_framework/test_node.py

            our_addr_and_port = f"{sockname[0]}:{sockname[1]}"
-            info = [peer for peer in self.getpeerinfo() if peer["addr"] == our_addr_and_port]
+            dst_addr_and_port = f"{p2p_conn.dstaddr}:{p2p_conn.dstport}"
+            info = [peer for peer in self.getpeerinfo() if peer["addr"] == our_addr_and_port and peer["addrbind"] == dst_addr_and_port]


⚠️ Potential issue | 🟠 Major

Handle optional addrbind safely in peer matching.

Line 723 assumes peer["addrbind"] always exists, but getpeerinfo documents addrbind as optional (src/rpc/net.cpp Line 108-115, 207-211). This can throw KeyError and reintroduce intermittent test failures.

Proposed fix

- info = [peer for peer in self.getpeerinfo() if peer["addr"] == our_addr_and_port and peer["addrbind"] == dst_addr_and_port] + peers = [peer for peer in self.getpeerinfo() if peer["addr"] == our_addr_and_port] + info = [peer for peer in peers if peer.get("addrbind") == dst_addr_and_port] + if not info: + # Fallback for peers where addrbind is not reported by getpeerinfo. + info = peers

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

info = [peer for peer in self.getpeerinfo() if peer["addr"] == our_addr_and_port and peer["addrbind"] == dst_addr_and_port]

peers = [peer for peer in self.getpeerinfo() if peer["addr"] == our_addr_and_port]

info = [peer for peer in peers if peer.get("addrbind") == dst_addr_and_port]

if not info:

# Fallback for peers where addrbind is not reported by getpeerinfo.

info = peers

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed. In `@test/functional/test_framework/test_node.py` at line 723, The peer matching assumes addrbind is always present and can raise KeyError; update the filter in test_node.py where getpeerinfo() is iterated (the list comprehension that builds info) to safely handle missing addrbind by using peer.get("addrbind") (or "in" check) when comparing to dst_addr_and_port, so replace peer["addrbind"] == dst_addr_and_port with a safe check such as peer.get("addrbind") == dst_addr_and_port to avoid KeyError for peers without addrbind while still matching addr and addrbind correctly for our_addr_and_port and dst_addr_and_port.

9d1dbbd scripted-diff: Fix bitcoin_config_h includes (TheCharlatan) Pull request description: As mentioned in bitcoin#26924 (comment) and bitcoin#29263 (comment), it is currently not safe to remove `bitcoin-config.h` includes from headers because some unrelated file might be depending on it. See also bitcoin#26972 for discussion. Solve this by including the file directly everywhere it's required, regardless of whether or not it's already included by another header. There should be no functional change here, but it will allow us to safely remove includes from headers in the future. ~I'm afraid it's a bit tedious to reproduce these commits, but it's reasonably straightforward:~ Edit: See note below ```bash # All commands executed from the src/ subdir. # Collect all tokens from bitcoin-config.h.in # Isolate the tokens and remove blank lines # Replace newlines with | and remove the last trailing one # Collect all files which use these tokens # Filter out subprojects (proper forwarding can be verified from Makefiles) # Filter out .rc files # Save to a text file git grep -E -l `grep undef config/bitcoin-config.h.in | cut -d" " -f2 | grep -v '^$' | tr '\n' '|' | sed 's/|$//'` | grep -v -e "^leveldb/" -e "^secp256k1/" -e "^crc32c/" -e "^minisketch/" -e "^Makefile" -e "\.rc$" > files-with-config-include.txt # Find all files from the above list which don't include bitcoin-config.h git grep -L -E "config/bitcoin-config.h" -- `cat files-with-config-include.txt` # Include them manually with the exception of some files in crypto: # crypto/sha256_arm_shani.cpp crypto/sha256_avx2.cpp crypto/sha256_sse41.cpp crypto/sha256_x86_shani.cpp # These are exceptions which don't use bitcoin-config.h, rather the Makefile.am adds these cppflags manually. # Commit changes. This should match the first commit of this PR. # Use the same search as above to find all files which DON'T use any config tokens git grep -E -L `grep undef config/bitcoin-config.h.in | cut -d" " -f2 | grep -v '^$' | tr '\n' '|' | sed 's/|$//'` | grep -v -e "^leveldb/" -e "^secp256k1/" -e "^crc32c/" -e "^minisketch/" -e "^Makefile" -e "\.rc$" > files-without-config-include.txt # Manually remove the includes and commit changes. This should match the second commit of this PR. ``` Edit: I'll keep this old description for posterity, but the manual approach has been replaced with a scripted diff from TheCharlatan ACKs for top commit: maflcko: ACK 9d1dbbd 🚪 TheCharlatan: ACK 9d1dbbd hebasto: ACK 9d1dbbd, I have reviewed the code and it looks OK. fanquake: ACK 9d1dbbd Tree-SHA512: f11ddc4ae6a887f96b954a6b77f310558ddb271088a3fda3edc833669c4251b7f392515224bbb8e5f67eb2c799b4ffed3b07d96454e82ec635c686d0df545872

…ching.py 8a20f76 test: drop duplicate getaddrs from p2p_getaddr_caching (Martin Zumsande) feb0096 test: fix intermittent failure in p2p_getaddr_caching (Martin Zumsande) Pull request description: Fixes bitcoin#28133 In the consistency check, it's not enough to check that our address/port is unique, only the combination of source and target must be unique. Otherwise, the OS may reuse ports for connections to different `-addrbind`, which was happening in the failed runs. While at it, the second commit cleans up duplicate `getaddr` messages in `p2p_getaddr_caching.py` that do nothing but generate `Ignoring repeated "getaddr"` log messages (and cleans up some whitespace the python linter complains about). ACKs for top commit: vasild: ACK 8a20f76 Tree-SHA512: eabe4727d7887f729074076f6333a918bba8cb34b8e3baaa83f167b441b0daa24f7c4824abcf03a9538a2ef14b2d826ff19aeffcb93a6c20735253a9678aac9c Fixing Linting error - 'time' module imported but not used

…ckscheduler RPC fabef12 refactor: Use EnsureAnyNodeContext (MarcoFalke) fa16406 test: Add SyncWithValidationInterfaceQueue to mockscheduler RPC (MarcoFalke) Pull request description: There should be no risk or downside in adding a call to `SyncWithValidationInterfaceQueue` here. In fact, it will make tests less brittle. For example, * If one sets the timeouts in `test/functional/feature_fee_estimation.py` to `0`, on `master` the test will fail and here it will pass. * It may avoid a rare (theoretic) intermittent issue in https://github.com/bitcoin/bitcoin/pull/28108/files#r1268966663 ACKs for top commit: TheCharlatan: ACK fabef12 furszy: Code review ACK fabef12. Convinced by checking all current tests usages. Tree-SHA512: c9e9a536a8721d1b3f267a66b40578b34948892301affdcad121ef8e02bf17037305d0dd53aa94b1b064753e66f9cfb31823b916b707a9d812627f502b818003

thepastaclaw

Code Review

Clean backport of three Bitcoin Core PRs: bitcoin-config.h includes cleanup (bitcoin#29404), p2p_getaddr_caching intermittent fix (bitcoin#28144), and SyncWithValidationInterfaceQueue in mockscheduler (bitcoin#28118). All upstream changes are correctly applied with appropriate Dash adaptations. The scripted-diff in bitcoin#29404 placed config includes mid-includes (after Dash-specific headers) in several files due to AWK boundary detection — cosmetic only, all files compile correctly.

Reviewed commit: ae9e403

🟡 1 suggestion(s)

1 additional finding

🟡 suggestion: Missing direct config include for src/util/system.cpp

src/util/system.cpp (lines 1-7)

Upstream bitcoin#29404 adds a direct #include <config/bitcoin-config.h> to src/common/system.cpp (renamed from src/util/system.cpp in bitcoin#28076). Dash still has the file at its original path and the backport does not add the config include. The file uses config symbols (HAVE_MALLOPT_ARENA_MAX, HAVE_FDATASYNC, etc.) but receives them transitively via util/system.h. Not blocking — matches upstream intent to eventually remove transitive config includes from headers.

🤖 Prompt for all review comments with AI agents

These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.

In `src/util/system.cpp`:
- [SUGGESTION] lines 1-7: Missing direct config include for src/util/system.cpp
  Upstream `bitcoin#29404` adds a direct `#include <config/bitcoin-config.h>` to `src/common/system.cpp` (renamed from `src/util/system.cpp` in `bitcoin#28076`). Dash still has the file at its original path and the backport does not add the config include. The file uses config symbols (`HAVE_MALLOPT_ARENA_MAX`, `HAVE_FDATASYNC`, etc.) but receives them transitively via `util/system.h`. Not blocking — matches upstream intent to eventually remove transitive config includes from headers.

vijaydasmp changed the title ~~Backport: Merge bitcoin/bitcoin#29404~~ backport : Merge bitcoin#29404 Feb 2, 2026

vijaydasmp changed the title ~~backport : Merge bitcoin#29404~~ backport: Merge bitcoin#29404 Feb 2, 2026

vijaydasmp changed the title ~~backport: Merge bitcoin#29404~~ backport: Merge bitcoin#29404, 28144, 28118 Feb 3, 2026

vijaydasmp force-pushed the Feb_2026_04 branch from b7df9cf to fb02f79 Compare February 3, 2026 16:28

github-actions bot added the needs rebase label Feb 15, 2026

vijaydasmp force-pushed the Feb_2026_04 branch from fb02f79 to 4f53d04 Compare February 17, 2026 00:53

vijaydasmp force-pushed the Feb_2026_04 branch from 4f53d04 to 191caec Compare February 17, 2026 01:21

github-actions bot removed the needs rebase label Feb 17, 2026

vijaydasmp force-pushed the Feb_2026_04 branch 4 times, most recently from 2779ae2 to 2cd9132 Compare February 26, 2026 08:22

vijaydasmp marked this pull request as ready for review February 26, 2026 11:28

github-actions bot mentioned this pull request Feb 28, 2026

backport: Merge bitcoin#28831, 28966 #7185

Closed

vijaydasmp force-pushed the Feb_2026_04 branch from 2cd9132 to 10a457b Compare March 3, 2026 23:56

coderabbitai bot reviewed Mar 4, 2026

View reviewed changes

This was referenced Mar 5, 2026

backport: Merge bitcoin#29260, 27832 #7201

Draft

feat!: migrate additional indexes from synchronous to async operation #7101

Open

github-actions bot mentioned this pull request Mar 24, 2026

backport : Merge bitcoin#26118, 27005, 27238, 27235, 27239, 27170, 23083, bitcoin-core/gui#726, 29254 #7245

Draft

fanquake added 3 commits March 25, 2026 08:39

vijaydasmp force-pushed the Feb_2026_04 branch from 10a457b to ae9e403 Compare March 25, 2026 03:09

github-actions bot mentioned this pull request Mar 26, 2026

backport: Merge bitcoin#26532, 28500, 28230, 26053, 19909 #7256

Draft

thepastaclaw reviewed Mar 26, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

backport: Merge bitcoin#29404, 28144, 28118#7124

backport: Merge bitcoin#29404, 28144, 28118#7124
vijaydasmp wants to merge 3 commits intodashpay:developfrom
vijaydasmp:Feb_2026_04

vijaydasmp commented Feb 2, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 2, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 15, 2026

Uh oh!

github-actions bot commented Feb 17, 2026

Uh oh!

coderabbitai bot commented Feb 26, 2026 •

edited

Loading

❌ Failed checks (1 warning)

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot Mar 4, 2026

Uh oh!

thepastaclaw left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

-            info = [peer for peer in self.getpeerinfo() if peer["addr"] == our_addr_and_port and peer["addrbind"] == dst_addr_and_port]
+            peers = [peer for peer in self.getpeerinfo() if peer["addr"] == our_addr_and_port]
+            info = [peer for peer in peers if peer.get("addrbind") == dst_addr_and_port]
+            if not info:
+                # Fallback for peers where addrbind is not reported by getpeerinfo.
+                info = peers

Conversation

vijaydasmp commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Potential Merge Conflicts Detected

Uh oh!

github-actions bot commented Feb 15, 2026

Uh oh!

github-actions bot commented Feb 17, 2026

Uh oh!

coderabbitai bot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Sequence Diagram(s)

Estimated code review effort

❌ Failed checks (1 warning)

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

thepastaclaw left a comment

Choose a reason for hiding this comment

Code Review

1 additional finding

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vijaydasmp commented Feb 2, 2026 •

edited

Loading

github-actions bot commented Feb 2, 2026 •

edited

Loading

coderabbitai bot commented Feb 26, 2026 •

edited

Loading