Skip to content

fix: register shareman recovery interface in ActiveContext #7244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PastaPastaPasta merged 1 commit into from
Mar 25, 2026
Merged

fix: register shareman recovery interface in ActiveContext #7244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/active/context.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ void ActiveContext::Start(CConnman& connman, PeerManager& peerman, int16_t worke
cl_signer->Start();
cl_signer->RegisterRecoveryInterface();
is_signer->RegisterRecoveryInterface();
shareman->RegisterRecoveryInterface();
Copy link
Copy Markdown
Author

@thepastaclaw thepastaclaw Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 Nitpick: Registration inconsistency: external wiring vs self-contained constructor

CEHFSignalsHandler self-registers as a CRecoveredSigsListener in its constructor (ehf_signals.cpp:28) and unregisters in its destructor (ehf_signals.cpp:33), making it impossible to forget. In contrast, shareman, cl_signer, and is_signer rely on ActiveContext::Start()/Stop() to call RegisterRecoveryInterface() externally — which is exactly how this bug was introduced. Moving registration into each object's constructor/destructor (or its own Start()/Stop()) would prevent this class of bug. Not blocking for this PR.

source: ['claude']


RegisterValidationInterface(cl_signer.get());
}
Expand All @@ -78,6 +79,7 @@ void ActiveContext::Stop()
{
UnregisterValidationInterface(cl_signer.get());

shareman->UnregisterRecoveryInterface();
is_signer->UnregisterRecoveryInterface();
cl_signer->UnregisterRecoveryInterface();
cl_signer->Stop();
Expand Down
Loading