Skip to content

fix: update DashSync to fix sweep balance Insight API URLs#754

Merged
bfoss765 merged 1 commit intomasterfrom
fix/sweep-balance
Mar 3, 2026
Merged

fix: update DashSync to fix sweep balance Insight API URLs#754
bfoss765 merged 1 commit intomasterfrom
fix/sweep-balance

Conversation

@bfoss765
Copy link
Copy Markdown
Contributor

@bfoss765 bfoss765 commented Feb 27, 2026

Summary

  • Update DashSyncCurrentCommit to point to DashSync fix/sweep-balance-url branch which fixes broken Insight API endpoints
  • Resolves "Couldn't sweep balance - Unexpected response from (null)" error when importing private keys

Root Cause

All three Insight API URLs in DSInsightManager.m were returning errors:

URL Old Status New URL New Status
insight.dash.org/insight-api-dash 404 insight.dash.org/insight-api 200
insight.dash.show/api Connection refused insight.dash.org/insight-api 200
testnet-insight.dashevo.org/insight-api-dash 502 insight.testnet.networks.dash.org/insight-api 200

Dependencies

Test plan

  • Import a private key with funds and verify sweep balance succeeds
  • Verify no "Unexpected response from (null)" error appears
  • Test on both mainnet and testnet

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated internal commit reference

Point to DashSync fix/sweep-balance-url branch (e272a368) which updates
the broken Insight API endpoints that caused "Couldn't sweep balance"
errors when importing private keys.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 562dddd and 022f633.

📒 Files selected for processing (1)
  • DashSyncCurrentCommit

📝 Walkthrough

Walkthrough

A commit hash reference was updated to a new identifier value. The change involves a single line modification with no alterations to logic, control flow, error handling, or public entity declarations.

Changes

Cohort / File(s) Summary
Commit Reference Update
Commit tracking configuration
Updated commit hash from 5e4545e0fefb2b2aa98c2209394898ea6cfcd43b to e272a368fa8b5a3fcaa637f5631352980dcc557f.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A hash has changed, from old to new,
One line swapped in morning dew,
No logic shifted, no flows askew,
Just a commit's fresh rendezvous! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating DashSync to fix Insight API URLs for sweep balance functionality.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/sweep-balance

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@HashEngineering HashEngineering self-requested a review March 2, 2026 01:49
Copy link
Copy Markdown
Contributor

@HashEngineering HashEngineering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent work.

@bfoss765 bfoss765 merged commit 44625a4 into master Mar 3, 2026
3 checks passed
@bfoss765 bfoss765 deleted the fix/sweep-balance branch March 3, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants