Skip to content

fix: replace abort() with cooperative wait in wait_for_run_task #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
xdustinface wants to merge 2 commits into
base: refactor/move-callbacks-to-crates
Choose a base branch
from

fix: replace `abort()` with cooperative wait in `wait_for_run_task`

fabbdad
Select commit
Loading
Failed to load commit list.
Draft

fix: replace abort() with cooperative wait in wait_for_run_task #576

fix: replace `abort()` with cooperative wait in `wait_for_run_task`
fabbdad
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 23, 2026 in 0s

66.51% (+0.18%) compared to 19fb152

View this Pull Request on Codecov

66.51% (+0.18%) compared to 19fb152

Details

Codecov Report

❌ Patch coverage is 78.63248% with 75 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.51%. Comparing base (19fb152) to head (fabbdad).
⚠️ Report is 1 commits behind head on refactor/move-callbacks-to-crates.

Files with missing lines Patch % Lines
dash-spv-ffi/src/bin/ffi_cli.rs 0.00% 39 Missing ⚠️
dash-spv/src/main.rs 0.00% 22 Missing ⚠️
dash-spv/src/client/event_handler.rs 95.71% 9 Missing ⚠️
dash-spv/src/client/sync_coordinator.rs 90.90% 3 Missing ⚠️
dash-spv-ffi/src/client.rs 90.90% 2 Missing ⚠️
Additional details and impacted files 
@@                          Coverage Diff                          @@
##           refactor/move-callbacks-to-crates     #576      +/-   ##
=====================================================================
+ Coverage                              66.32%   66.51%   +0.18%     
=====================================================================
  Files                                    311      312       +1     
  Lines                                  64976    65018      +42     
=====================================================================
+ Hits                                   43097    43247     +150     
+ Misses                                 21879    21771     -108
Files with missing lines Coverage Δ
dash-spv-ffi/src/callbacks.rs 79.59% <100.00%> (+16.11%) ⬆️
dash-spv/src/client/core.rs 46.00% <100.00%> (+1.10%) ⬆️
dash-spv/src/client/events.rs 100.00% <100.00%> (ø)
dash-spv/src/client/lifecycle.rs 64.15% <100.00%> (+0.68%) ⬆️
dash-spv/src/client/mempool.rs 57.57% <ø> (ø)
dash-spv/src/client/mod.rs 98.64% <100.00%> (ø)
dash-spv/src/client/queries.rs 14.28% <ø> (ø)
dash-spv/src/client/transactions.rs 0.00% <ø> (ø)
dash-spv-ffi/src/client.rs 58.73% <90.90%> (-0.66%) ⬇️
dash-spv/src/client/sync_coordinator.rs 82.45% <90.90%> (+9.72%) ⬆️
... and 3 more

... and 4 files with indirect coverage changes

View more details on Codecov