Skip to content

fix: reject zeroed `FFIBlockInfo` for confirmed transaction contexts

5114330
Select commit
Loading
Failed to load commit list.
Open

refactor: store TransactionContext in TransactionRecord #582

fix: reject zeroed `FFIBlockInfo` for confirmed transaction contexts
5114330
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 25, 2026 in 0s

66.82% (+0.08%) compared to 2f34963

View this Pull Request on Codecov

66.82% (+0.08%) compared to 2f34963

Details

Codecov Report

❌ Patch coverage is 66.91176% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.82%. Comparing base (2f34963) to head (5114330).

Files with missing lines Patch % Lines
key-wallet-ffi/src/types.rs 58.49% 22 Missing ⚠️
key-wallet-ffi/src/transaction.rs 0.00% 8 Missing ⚠️
key-wallet-ffi/src/transaction_checking.rs 0.00% 8 Missing ⚠️
key-wallet-ffi/src/wallet_manager.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           v0.42-dev     #582      +/-   ##
=============================================
+ Coverage      66.73%   66.82%   +0.08%     
=============================================
  Files            313      313              
  Lines          64948    64939       -9     
=============================================
+ Hits           43346    43393      +47     
+ Misses         21602    21546      -56     
Files with missing lines Coverage Δ
key-wallet-ffi/src/managed_account.rs 46.94% <100.00%> (+3.03%) ⬆️
key-wallet/src/managed_account/mod.rs 47.91% <100.00%> (-1.54%) ⬇️
...y-wallet/src/managed_account/transaction_record.rs 100.00% <100.00%> (ø)
...et/src/transaction_checking/transaction_context.rs 48.48% <100.00%> (ø)
...-wallet/src/transaction_checking/wallet_checker.rs 96.55% <100.00%> (+0.01%) ⬆️
key-wallet-ffi/src/wallet_manager.rs 53.17% <0.00%> (-0.65%) ⬇️
key-wallet-ffi/src/transaction.rs 0.00% <0.00%> (ø)
key-wallet-ffi/src/transaction_checking.rs 1.66% <0.00%> (+<0.01%) ⬆️
key-wallet-ffi/src/types.rs 68.44% <58.49%> (+9.24%) ⬆️

... and 3 files with indirect coverage changes