Keep DaskCluster in the Created phase until all components exist - #977
Open
bnaul wants to merge 2 commits into
Open
Keep DaskCluster in the Created phase until all components exist#977bnaul wants to merge 2 commits into
bnaul wants to merge 2 commits into
Conversation
daskcluster_create_components is a kopf field handler that only matches while status.phase == "Created". If it fails once and handle_scheduler_service_status moves the phase to Running before the retry runs, kopf drops the retry and the default DaskWorkerGroup is never created. Leave the phase alone in handle_scheduler_service_status while the cluster is Created, and let daskcluster_create_components set the final phase from the scheduler Service state once every component exists. This also stops Pending from overwriting an earlier Running. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SDXhtGmuPdnM98aP4HnxQE
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #976.
daskcluster_create_componentsonly matches whilestatus.phase == "Created". If it fails once andhandle_scheduler_service_statusmoves the phase toRunningbefore the retry runs, kopf drops the retry and the defaultDaskWorkerGroupis never created.handle_scheduler_service_statusno longer changes the phase while the cluster is stillCreated.daskcluster_create_componentssets the phase itself once all components exist (Running, orPendingfor aLoadBalancerservice without ingress) instead of always writingPending. This also stopsPendingfrom overwritingRunning(DaskCluster stuck in Pending state - Possible race condition? #968).