-
Notifications
You must be signed in to change notification settings - Fork 16
ENH: new function union1d
#495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Relevant upstream context from data-apis/array-api#25 @kgryte :
Given @paddyroddy's analysis in gh-491, it looks like absence from PyTorch might still be a blocker for inclusion in the standard? If so, probably fine to proceed with this PR. |
lucascolley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @OmarManzoor, looks good!
|
@hameerabbasi is there an existing discussion about @OmarManzoor in the meantime, would wrapping the |
|
@lucascolley Sorry about being a bit late in updating this. I wrapped the return value in |
I can try to dig one up, but yes, that's the policy as of right now. |
lucascolley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @OmarManzoor !
Can you add this to https://github.com/data-apis/array-api-extra/blob/main/docs/api-reference.md and check that pixi run open-docs looks good?
lucascolley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @OmarManzoor !
Fixes #491
union1dfunction.