Skip to content

Conversation

@sawantpritam
Copy link
Contributor

@sawantpritam sawantpritam commented Mar 21, 2022

@itsankit-google @rmstar Please review.

PR contains changes for CDAP-18889 and CDAP-18892 :

  1. Add tests with Service Account Type as macro param (JSON)
  2. Capture logs of preview run

@google-cla
Copy link

google-cla bot commented Mar 21, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@itsankit-google itsankit-google added the build Trigger unit test build label Mar 21, 2022
@sawantpritam
Copy link
Contributor Author

Depends on cdapio/cdap-e2e-tests#82

@sawantpritam
Copy link
Contributor Author

Conflict resolved.

@sawantpritam sawantpritam reopened this Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Trigger unit test build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants