Fix: Sort entities before merging adjacent same-type entities - #2238
Open
raniaemran wants to merge 1 commit into
Open
Fix: Sort entities before merging adjacent same-type entities#2238raniaemran wants to merge 1 commit into
raniaemran wants to merge 1 commit into
Conversation
- Added sorting by start position in _merge_entities_with_spaces_between() - This ensures entities are merged correctly even when input list is unsorted - Added regression test for unsorted input scenario - Fixes Issue data-privacy-stack#1090 and data-privacy-stack#1573
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
What does this PR do?
startposition in_merge_entities_with_spaces_between()Why is this needed?
<PERSON>RaniaExample
Before: