Add --update flag to install.sh for easy version updates#287
Open
CheeYuTan wants to merge 2 commits intodatabricks-solutions:mainfrom
Open
Add --update flag to install.sh for easy version updates#287CheeYuTan wants to merge 2 commits intodatabricks-solutions:mainfrom
CheeYuTan wants to merge 2 commits intodatabricks-solutions:mainfrom
Conversation
Addresses issues databricks-solutions#232, databricks-solutions#167, and databricks-solutions#137 — users had no clear way to update skills after initial install since skills are copied to tool-specific directories and git pull only updates the MCP server. Changes: - install.sh: Add --update flag that loads saved install config (tools, scope, profile) and re-runs with --force, no prompts - install.sh: Add save_config/load_config functions to persist install settings to ~/.ai-dev-kit/install.conf - README.md: Add "Updating to the Latest Version" section with clear instructions and explanation of why --update is needed - Fix pre-existing ruff format issues in auth.py and test_sql.py
load_config now restores SAVED_BASE_DIR so project-scoped installs update the correct .cursor/skills/ and .claude/skills/ paths even when --update is run from a different working directory.
Collaborator
|
@CheeYuTan today, we expect that folks will just re-run installation in order to update! |
Contributor
Author
|
Is there any value that you see in adding the update flag? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #232, #167, and #137 — users have no clear way to update ai-dev-kit after initial install. Skills are copied to tool-specific directories (e.g.,
~/.cursor/skills/), sogit pullon the repo only updates the MCP server source, not the copied skills.This PR adds:
install.sh--updateflag that loads saved install config and re-runs with--force(no interactive prompts)install.shsave_config()/load_config()to persist install settings to~/.ai-dev-kit/install.confREADME.md--updateand why it's neededauth.py,test_sql.pyruff formatissues onmainHow it works
~/.ai-dev-kit/install.conf--updatereads that config, setsFORCE=trueandSILENT=true, then runs the full install pipeline--forceas a fallback (documented in README)Usage
Test plan
~/.ai-dev-kit/install.confwith correct values--updatereads config and skips all interactive prompts--updatefails gracefully with clear error if no saved config exists--forcestill works as before (backward compatible)bash -n install.shpasses syntax check