nextchanges: Prepare for upstream changes to tagging.py - #6029
Open
janniklasrose wants to merge 8 commits into
Open
nextchanges: Prepare for upstream changes to tagging.py#6029janniklasrose wants to merge 8 commits into
janniklasrose wants to merge 8 commits into
Conversation
…ike in the upstream flow
janniklasrose
marked this pull request as ready for review
July 22, 2026 16:28
Collaborator
Integration test reportCommit: 899dce5
8 interesting tests: 4 RECOVERED, 4 SKIP
Top 3 slowest tests (at least 2 minutes):
|
pietern
approved these changes
Jul 23, 2026
pietern
left a comment
pietern
left a comment
Contributor
There was a problem hiding this comment.
Is release_tagging.py still functional after tagging.py is updated?
Contributor
Author
Good question @pietern! TL;DR: identical behaviour, it's safe if we forget to cut over during the next genkit run. Full explanation: Once the upstream changes are merged, doing a our release_tagging.py monkey-patches the following methods to its own version:
|
…nges-prep-for-upstream-changes
The wrapper is removed later in this stack, so naming the file here goes stale; the behavior it describes is what matters. Co-authored-by: Isaac
janniklasrose
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Tagging logic currently in release_tagging.py is being upstreamed. This includes README.md inside a fragment being treated as a normal fragment and reading the sections from .codegen.json.
Once upstream changes land, they will make their way into CLI via the next run of genkit. We will then be able to drop release_tagging.py and change tagging.yml rewrite to point back at tagging.py.
Why
Align with upcoming upstream changes.
Stack 🥞 : #6029 (this) > #6141 > #6036
Tests
Locally