Support dots in target names when writing to an override block - #6148
Open
ilyakuz-db wants to merge 1 commit into
Open
Support dots in target names when writing to an override block#6148ilyakuz-db wants to merge 1 commit into
ilyakuz-db wants to merge 1 commit into
Conversation
Contributor
Approval status: pending
|
Collaborator
Integration test reportCommit: 1544e89
8 interesting tests: 4 RECOVERED, 4 SKIP
Top 9 slowest tests (at least 2 minutes):
|
ilyakuz-db
force-pushed
the
configsync/dotted-target-name
branch
from
August 3, 2026 15:43
03fd794 to
04c769a
Compare
ilyakuz-db
force-pushed
the
configsync/split-list-write-back
branch
from
August 3, 2026 16:04
49300b3 to
8b3e0a8
Compare
ilyakuz-db
force-pushed
the
configsync/dotted-target-name
branch
3 times, most recently
from
August 3, 2026 16:32
0df0b5d to
b4c479d
Compare
ilyakuz-db
force-pushed
the
configsync/dotted-target-name
branch
2 times, most recently
from
August 3, 2026 17:26
71e1909 to
8b3fd57
Compare
Co-authored-by: Isaac
ilyakuz-db
force-pushed
the
configsync/dotted-target-name
branch
from
August 3, 2026 19:21
8b3fd57 to
1544e89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A target name may contain a dot —
targets: {dev.eu: ...}passesbundle validateand deploys. But write-back addresses an override block by buildingtargets.<target>.<field>as a string, which is then parsed back into path segments. A dotted name splits into two keys, so the write targets/targets/dev/eu/...and the command fails outright:Pre-existing, not introduced by #6138:
mainfails the same way with a different message.Solution
Build the prefix as path nodes instead of concatenating text.
structpath.NewPatternStringKeyalready switches to bracket notation for a name that is not a plain field, sodev.eurenders astargets['dev.eu']and round-trips as one key. Both the routed path and the unrouted fallback go through the same helper.Tests
split/dotted_targetedits a field in the override block of a target nameddev.eu. It fails on both engines without this change (non-zero exit, nothing written) and passes with it. No other golden changes.