Fix logging when an OFF connection initializes first - #1670
Merged
Conversation
Signed-off-by: Cathleen Yan <cathleen.yan@databricks.com>
![peco-review-bot[bot]](https://avatars.githubusercontent.com/in/3801177?s=60&v=4){kind=small}
gopalldb
reviewed
Aug 30, 2026
| handler.setLevel(level); | ||
| handler.setFormatter(new Slf4jFormatter()); | ||
| jdbcJulLogger.addHandler(handler); | ||
| if (isLoggerInitialized) { |
Collaborator
There was a problem hiding this comment.
the issue will still remain, logger will remain disabled if first connection had it disabled
Collaborator
Author
There was a problem hiding this comment.
I verified the OFF to enabled change. The OFF path returns without setting isLoggerInitialized, so the later enabled call installs a handler, updates the logger level, and marks initialization complete. testInitLoggerPromotesFromOffToEnabled covers this, and I also tested locally
gopalldb
reviewed
Aug 30, 2026
gopalldb
reviewed
Aug 30, 2026
| // parent package logger. Using "com.databricks" as the prefix captures all JDBC driver | ||
| // classes as well as shaded dependencies (SDK, Apache HTTP client, etc.) | ||
| Logger jdbcJulLogger = Logger.getLogger(PARENT_CLASS_PREFIX); | ||
| jdbcJulLogger.setUseParentHandlers(false); |
Collaborator
There was a problem hiding this comment.
do we want to set this on OFF only path? This can be done after checking OFF level
Collaborator
Author
There was a problem hiding this comment.
The OFF path needs it to prevent logs from propagating to root handlers, so both the OFF path and enabled path need this
Signed-off-by: Cathleen Yan <58714163+cathleeny@users.noreply.github.com>
gopalldb
approved these changes
Sep 7, 2026
cathleeny
enabled auto-merge
September 8, 2026 16:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix process-wide JUL initialization when the first connection uses
LogLevel=OFF.OFFsuppresses the shared parent logger without creating a handler or permanently completing initialization.OFFconnections—do not reconfigure the logger.Testing
OFF -> TRACE,TRACE -> OFF, concurrent initialization without duplicate handlers, and retry after failed handler creation.JulLoggerTestandLoggingUtilTest: 30 tests passed.OFF -> TRACEcreates one handler, whileTRACE -> OFFretains the original handler and level.Additional Notes to the Reviewer
This is the short-term fix and intentionally keeps handler creation inside
JulLogger.initLogger().