Add AI tools integration - #2025
Conversation
|
🤖 Integration tests ❌ 2 of 35 test jobs failed for |
|
🤖 Integration tests ❌ 2 of 35 test jobs failed for |
|
🤖 Integration tests ✅ all 35 test jobs passed for |
|
🤖 Integration tests ✅ all 35 test jobs passed for |
|
🤖 Integration tests triggered for |
|
🤖 Integration tests ❌ 3 of 35 test jobs failed for |
rugpanov
left a comment
rugpanov
left a comment
There was a problem hiding this comment.
LGTM — approving. The mutex serialization and the empty-agent-selection guard both look good now, and the test coverage is genuinely thorough (the concurrency test at AiToolsManager.test.ts:755 would actually fail if serialization broke).
Two things I'd like fixed as soon as possible, neither blocking this merge:
- Cancelling an operation is reported as a failure — cosmetically a wrong toast, but it also records
result: "error"telemetry, so every cancellation inflates the AI-tools error rate. Worth landing before the release that enables this for users, since that data can't be cleaned up retroactively. - No re-detect when the active project changes — narrow repro (multi-root, multiple Databricks projects, explicit "Choose a project"), and recoverable via the reload affordance, but the model and the CLI cwd disagree until something re-detects.
Details inline.
## Changes Stacked on #2025 - make command progress toasts non-cancellable - subscribe to `workspaceFolderManager.onDidChangeActiveProjectFolder` and refresh AI tools state ## Tests Added unit tests
|
🤖 Integration tests triggered for |
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
|
🤖 Integration tests ❌ 8 of 35 test jobs failed for |
3 participants
Changes
Integrate the
databricks aitoolsfamily of commands into the extension.AI toolsrow to the configuration paneTests
Added tests pass