Skip to content

Restore unspecified enum wire values - #288

Open
tejaskochar-db wants to merge 1 commit into
mainfrom
drop-default-unspecified-enum-members
Open

Restore unspecified enum wire values#288
tejaskochar-db wants to merge 1 commit into
mainfrom
drop-default-unspecified-enum-members

Conversation

@tejaskochar-db

@tejaskochar-db tejaskochar-db commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes existing *_UNSPECIFIED enum constants so they use the values declared by the API instead of the empty string. No enum constants are removed.

This supersedes #270, which introduced the empty-string mapping.

Why

The empty-string mapping changed the serialized value of these constants and broke compatibility with APIs that expect their declared enum strings. This fix keeps the existing TypeScript constants and restores the wire values they represent.

Whether these constants should be removed from the public API is intentionally deferred to a separate decision.

What changed

Interface changes

  • No constants were added or removed.

Behavioral changes

  • Fixed the declared string values of 202 existing *_UNSPECIFIED constants across 49 packages.
  • Serializing an affected constant now sends its declared *_UNSPECIFIED string instead of an empty string.

Internal changes

  • Regenerated the affected model files.
  • Added a bug-fix changelog entry to every affected package.

How is this tested?

npm run ci passes, including builds, linting, formatting checks, type checking, Node tests, browser tests, and license validation.

@tejaskochar-db
tejaskochar-db force-pushed the drop-default-unspecified-enum-members branch from 722dab9 to dcc936b Compare August 4, 2026 12:14
@tejaskochar-db tejaskochar-db changed the title Remove default unspecified enum constants Restore unspecified enum wire values Aug 4, 2026
@tejaskochar-db
tejaskochar-db marked this pull request as ready for review August 4, 2026 12:29
@tejaskochar-db
tejaskochar-db force-pushed the drop-default-unspecified-enum-members branch from dcc936b to 392cd98 Compare August 5, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants