Restore unspecified enum wire values - #288
Open
tejaskochar-db wants to merge 1 commit into
Open
Conversation
tejaskochar-db
force-pushed
the
drop-default-unspecified-enum-members
branch
from
August 4, 2026 12:14
722dab9 to
dcc936b
Compare
tejaskochar-db
marked this pull request as ready for review
August 4, 2026 12:29
tejaskochar-db
force-pushed
the
drop-default-unspecified-enum-members
branch
from
August 5, 2026 16:40
dcc936b to
392cd98
Compare
parthban-db
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes existing
*_UNSPECIFIEDenum constants so they use the values declared by the API instead of the empty string. No enum constants are removed.This supersedes #270, which introduced the empty-string mapping.
Why
The empty-string mapping changed the serialized value of these constants and broke compatibility with APIs that expect their declared enum strings. This fix keeps the existing TypeScript constants and restores the wire values they represent.
Whether these constants should be removed from the public API is intentionally deferred to a separate decision.
What changed
Interface changes
Behavioral changes
*_UNSPECIFIEDconstants across 49 packages.*_UNSPECIFIEDstring instead of an empty string.Internal changes
How is this tested?
npm run cipasses, including builds, linting, formatting checks, type checking, Node tests, browser tests, and license validation.