Skip to content

Conversation

@m-abulazm
Copy link
Contributor

@m-abulazm m-abulazm commented Nov 13, 2025

Changes

What does this PR do?

adds an end-to-end (e2e) test for reconcile to validate the setup of testing reconcile e2e

Relevant implementation details

  • adds first e2e test
  • moves older ignored reconcile specs that needed sandbox infra access

Caveats/things to watch out for when reviewing:

  • this does not e2e test all sources and more tests will be added in following PRs

Tests

  • added acceptance tests

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

❌ Patch coverage is 78.78788% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.11%. Comparing base (7b2b716) to head (825a122).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/databricks/labs/lakebridge/cli.py 66.66% 2 Missing and 2 partials ⚠️
src/databricks/labs/lakebridge/deployment/job.py 70.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2145      +/-   ##
==========================================
- Coverage   64.18%   64.11%   -0.07%     
==========================================
  Files         100      100              
  Lines        8624     8624              
  Branches      893      893              
==========================================
- Hits         5535     5529       -6     
- Misses       2919     2923       +4     
- Partials      170      172       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Nov 13, 2025

✅ 51/51 passed, 6 flaky, 4m11s total

Flaky tests:

  • 🤪 test_transpiles_informatica_to_sparksql_non_interactive[False] (20.562s)
  • 🤪 test_transpiles_informatica_to_sparksql (23.969s)
  • 🤪 test_transpile_teradata_sql_non_interactive[True] (23.826s)
  • 🤪 test_transpiles_informatica_to_sparksql_non_interactive[True] (5.386s)
  • 🤪 test_transpile_teradata_sql (6.829s)
  • 🤪 test_transpile_teradata_sql_non_interactive[False] (5.897s)

Running from acceptance #3329

@m-abulazm m-abulazm changed the title add e2e reconcile test add e2e reconcile test for databricks source Nov 14, 2025
@m-abulazm m-abulazm marked this pull request as ready for review November 14, 2025 16:35
@m-abulazm m-abulazm requested a review from a team as a code owner November 14, 2025 16:35
asnare
asnare previously requested changes Dec 24, 2025
@asnare asnare dismissed their stale review December 29, 2025 13:42

Requested changes have been made.

Copy link
Collaborator

@sundarshankar89 sundarshankar89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


def uninstall(self, config: LakebridgeConfiguration):
# This will remove all the Lakebridge modules
if not self._prompts.confirm(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this logic is moved inside uninstall.

@m-abulazm m-abulazm enabled auto-merge January 8, 2026 15:45
@m-abulazm m-abulazm added this pull request to the merge queue Jan 8, 2026
Merged via the queue into main with commit d487ff7 Jan 8, 2026
6 checks passed
@m-abulazm m-abulazm deleted the e2e/reconcile branch January 8, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal technical pr's not end user facing tech debt design flaws and other cascading effects

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants