-
Notifications
You must be signed in to change notification settings - Fork 81
add e2e reconcile test for databricks source #2145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2145 +/- ##
==========================================
- Coverage 64.18% 64.11% -0.07%
==========================================
Files 100 100
Lines 8624 8624
Branches 893 893
==========================================
- Hits 5535 5529 -6
- Misses 2919 2923 +4
- Partials 170 172 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✅ 51/51 passed, 6 flaky, 4m11s total Flaky tests:
Running from acceptance #3329 |
sundarshankar89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
|
||
| def uninstall(self, config: LakebridgeConfiguration): | ||
| # This will remove all the Lakebridge modules | ||
| if not self._prompts.confirm( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this logic is moved inside uninstall.
Changes
What does this PR do?
adds an end-to-end (e2e) test for reconcile to validate the setup of testing reconcile e2e
Relevant implementation details
Caveats/things to watch out for when reviewing:
Tests