Add support for worker versioning.#389
Open
EdsonPetry wants to merge 15 commits intodatafusion-contrib:mainfrom
Open
Add support for worker versioning.#389EdsonPetry wants to merge 15 commits intodatafusion-contrib:mainfrom
EdsonPetry wants to merge 15 commits intodatafusion-contrib:mainfrom
Conversation
gabotechs
reviewed
Mar 25, 2026
Fix broken code examples in worker.md: restore missing env var snippet, correct proto field name (version_number → version), replace LruCache with HashMap, fix misaligned zip iterator bug, and add channel_resolver parameter to the resolver constructor. Export get_worker_version() and add background_version_resolver to the library for use by downstream consumers.
EdsonPetry
force-pushed
the
edson.petry/worker-versioning
branch
from
9895b35 to
5b96300
Compare
EdsonPetry
force-pushed
the
edson.petry/worker-versioning
branch
from
48d4cc7 to
434f28d
Compare
gabotechs
reviewed
Apr 14, 2026
EdsonPetry
force-pushed
the
edson.petry/worker-versioning
branch
from
8b4f825 to
815cdac
Compare
gabotechs
reviewed
Apr 14, 2026
Collaborator
There was a problem hiding this comment.
It'd be nice if we can keep the existing localhost_run.rs and localhost_worker.rs simple as before, and have either a specific example dedicated to versioning. What do you think?
Address PR review feedback: - Remove `get_worker_version` helper (too trivial for a public API fn) - Inline the RPC call in the docs example - Restore `localhost_run.rs` and `localhost_worker.rs` to their simple pre-versioning state - Add dedicated `localhost_versioned_run.rs` and `localhost_versioned_worker.rs` examples for version filtering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #380
Summary
GetWorkerInfogRPC endpoint toworker.protoso workers can report a user-defined version string, enabling coordinators to filter by version during rolling deploymentsWorker::with_version()builder method and exportGetWorkerInfoRequest/GetWorkerInfoResponsefrom the crate rootdocs/localhost_workerandlocalhost_runexamples with--versionflags