58 CI automation of test suite #154
Conversation
…e test we don't really need export-specific packages
…ma creation a class-level op
…fns are available after installing adelphi Python package. Also cleaned up some unused imports and some excessive logging configs.
…simplify the import of functionality from adelphi packages. Also simplify the dependency specification; test-requirements.txt really should be testing-only stuff now.
…elphi (since this will in turn be required for tox)
…orrectly report failure
…ons which returned a non-zero status code themselves
… tests correctly report failure" This reverts commit 5221b74.
|
|
||
| # Functions and constants related to the anonymization process | ||
| from adelphi.store import get_standard_columns_from_table_metadata | ||
| import re |
There was a problem hiding this comment.
Randomly discovered unused import, presumably a holdover from previous changes
|
|
||
| from github import Github | ||
|
|
||
| logging.basicConfig(level=logging.INFO) |
There was a problem hiding this comment.
This (and store.py below) should definitely not be setting up their own logging... they should be leveraging logs that are configured somewhere else.
| return PlainTextAuthProvider(username=username, password=password) | ||
|
|
||
|
|
||
| @retry |
There was a problem hiding this comment.
Annotated to make this a tenacity-aware function but we don't provide global configs here since those are largely context-specific. Individual callers can provide args appropriate for their specific use; see the example in test-adelphi to see what this looks like.
| except SystemExit: | ||
| pass | ||
| except SystemExit as exc: | ||
| exitCodes.append(exc.code) |
There was a problem hiding this comment.
The exit code that would be returned by tox lives in SystemExit.code. We need to trap this to determine how many of our tox "invocations" resulted in successful tests.
| click ~= 7.1 | ||
| cassandra-driver ~= 3.24 | ||
| docker ~= 4.4 | ||
| tenacity ~= 7.0 |
There was a problem hiding this comment.
Now that test-adelphi is a full-fledged part of the Python package (see setup.py change above) there isn't any need to manage it's dependencies via test requirements. This change was one of the significant arguments for making test-adelphi part of the package.
|
Look at "Checks" on this PR to see the output of running a complete test suite on the code in this PR. |
| push: | ||
| branches: [ 115-breadth-first-testing ] | ||
| pull_request: | ||
| branches: [ 115-breadth-first-testing ] |
There was a problem hiding this comment.
A temporary config (since this is branched off of the feature branch changing the integration test framework). This will need to be changed to the default branch before we actually merge it in.
|
Closing in favor of #160 |
No description provided.