chore: drop multi-language support, English-only - #11
Merged
Conversation
Reduce SUPPORTED_LANGUAGE_CODES to just 'en' and remove everything that existed to generate/maintain the other 10 locales: - Delete non-English translation catalogs (de/es/fr/it/ja/ko/nl/pl/ pt-BR/zh, plus a stray unused sq catalog) - Remove the Crowdin pipeline: translations-upload.yml (extracted strings and opened a PR on every push to main), translations-pull.yml (pulled from Crowdin every 2h), translations-force-pull.yml, and crowdin.yml - Trim the SUPPORTED_LANGUAGES display record in i18n.ts to match - Remove the language-switcher UI (account menu, org menu, and the Ctrl+K command palette) and its LanguageSwitcherDialog component, since there's only one language to switch to - Remove the now-dead /api/locale route those switchers posted to Verified translate:extract/compile only touch the en catalog and tsc --noEmit is clean.
There was a problem hiding this comment.
Pull request overview
This PR reduces the application’s internationalization surface area to English-only by trimming supported locale constants, removing language-switcher UI + its persistence route, and deleting Crowdin automation/config so translation PR churn stops.
Changes:
- Restricts supported language codes and display labels to
enonly. - Removes language switching UX (menus + command palette) and deletes the
/api/localeroute. - Deletes Crowdin config and translation upload/pull GitHub workflows.
Reviewed changes
Copilot reviewed 11 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/ui/components/common/language-switcher-dialog.tsx | Removes the reusable language-switcher dialog component. |
| packages/lib/constants/locales.ts | Reduces supported language codes to ['en'] and keeps i18n options aligned. |
| packages/lib/constants/i18n.ts | Shrinks SUPPORTED_LANGUAGES to English-only. |
| crowdin.yml | Removes Crowdin file mapping configuration. |
| apps/remix/app/routes/api+/locale.tsx | Deletes the locale-setting endpoint used by the language switchers. |
| apps/remix/app/components/general/org-menu-switcher.tsx | Removes the org menu’s language-switcher entry and dialog wiring. |
| apps/remix/app/components/general/menu-switcher.tsx | Removes the account menu’s language-switcher entry and dialog wiring. |
| apps/remix/app/components/general/app-command-menu.tsx | Removes “change language” commands from the command palette. |
| .github/workflows/translations-upload.yml | Removes automated extraction/upload workflow. |
| .github/workflows/translations-pull.yml | Removes scheduled Crowdin pull workflow. |
| .github/workflows/translations-force-pull.yml | Removes manual force-pull workflow. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
25
to
29
| export const SUPPORTED_LANGUAGES: Record<string, SupportedLanguage> = { | ||
| de: { | ||
| short: 'de', | ||
| full: msg`German`, | ||
| }, | ||
| en: { | ||
| short: 'en', | ||
| full: msg`English`, | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduces the app to English-only and removes everything that existed to generate/maintain the other 10 locales.
SUPPORTED_LANGUAGE_CODESto justen(packages/lib/constants/locales.ts) and the matchingSUPPORTED_LANGUAGESdisplay record (i18n.ts)sqcatalogtranslations-upload.yml— extracted strings and opened achore/extract-translationsPR on every push tomaintranslations-pull.yml— pulled from Crowdin every 2 hourstranslations-force-pull.yml— manual force-pullcrowdin.yml— the source/locale file mappingCtrl+Kcommand palette) and itsLanguageSwitcherDialogcomponent, since there's only one language to switch to/api/localeroute those switchers posted toWhy
This stops the repeated automated "chore: extract translations" / "chore: add translations" PRs and the 2-hourly Crowdin pull workflow.
Verification
npm run translate:extract/translate:compileonly touch theencatalogtsc --noEmitclean on bothpackages/libandapps/remix