-
Notifications
You must be signed in to change notification settings - Fork 16
Fix/added json ld feature #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Updated all JSON-LD sameAs arrays to use only external social media links - Removed internal links (olake.io/slack/, olake.io/webinar/) from sameAs - Now using: GitHub, X (Twitter), LinkedIn, and YouTube links only - Addresses review feedback about Google potentially ignoring objects with internal links
- Changed all addressCountry values from 'USA' to 'US' for consistency - Updated 5 files: about-us.jsx, ai-lake.tsx, index.jsx, BlogListPage, BlogPostPage - All US addresses now consistently use ISO country code 'US'
- Changed all US addressCountry values to 'USA' for consistency - Updated 10 files to use 'USA' instead of 'US' - India office address remains 'IN' in contact.tsx
src/pages/contact.tsx
Outdated
| hasPOS: { | ||
| '@type': 'Place', | ||
| name: 'OLake - Working Office (Bengaluru)', | ||
| address: { | ||
| '@type': 'PostalAddress', | ||
| streetAddress: '2nd floor, Monte carlo building, 27th Main Rd, Parangi Palaya, Sector 2, HSR Layout', | ||
| addressLocality: 'Bengaluru', | ||
| addressRegion: 'Karnataka', | ||
| postalCode: '560102', | ||
| addressCountry: 'IN' | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not needed as we are not doing any POS(Point of Sale) as we are a tech company. this is typically used for retail companies.
| addressLocality: 'LEWES', | ||
| addressRegion: 'DE', | ||
| postalCode: '19958', | ||
| addressCountry: 'USA' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to Schema.org PostalAddress documentation, addressCountry should use ISO 3166-1 alpha-2 country codes (e.g., "US", "GB", "CA"), not full country names.
✅ Removed hasPOS section from contact.tsx: - hasPOS is not needed for tech companies (typically used for retail) - Removed the entire hasPOS object (lines 51-62) ✅ Fixed country code format to ISO 3166-1 alpha-2: - Changed addressCountry from 'USA' to 'US' in contact.tsx - Changed addressCountry from 'USA' to 'US' in contributors/index.tsx - Follows Schema.org PostalAddress documentation standards
Added a json ld script for each page