fix: adjust sidecar webhook processing #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The webhook processor should use the `.items` as the output from the stage because vector will automatically convert each array element into it's own log entry. This will result in vector sending individual log events through the pipeline after this stage. I also remove an unnecessary stage that was adding a source / cluster label to each log entry.
JoseSzycho
approved these changes
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves an issue where a webhook batch wasn't being parsed correctly into individual audit log events that could be processed by the pipeline. This was resulting in clickhouse storing the entire batch of audit events in a single row.
{ "kind": "EventList", "apiVersion": "audit.k8s.io/v1", "items": [ { "kind": "Event", ... }, { "kind": "Event", ... } ] }It's expected the pipeline will take the above batch of events sent to the webhook and convert it into individual logs:
{ "kind": "Event", ... },Detail
The webhook processor should use the
.itemsas the output from the stage because vector will automatically convert each array element into its own log entry. This will result in vector sending individual log events through the pipeline after this stage.I also remove an unnecessary stage that was adding a source / cluster label to each log entry.
Relates to https://github.com/datum-cloud/engineering/issues/90